cargdev/angular
1
0
Fork 0
Code Issues 8 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(core): undecorated-classes-with-di migration should never use ngtsc (#32318)

Browse Source 
ec4381dd40 enabled Ivy by default. This is
problematic as migrations like `undecorated-classes-with-di` depend on the
`AngularCompilerProgram` (NGC) in order to perform the migration from
version 8 to version 9. In order to ensure that the migration always runs
with NGC (and doesn't get the `NgtscProgram`), we need to explicitly disable
ivy when creating the `@angular/compiler-cli` program for the migration.

PR Close #32318
This commit is contained in:
Paul Gschwendtner
2019-08-26 16:11:37 +02:00
committed by Miško Hevery
parent b094936d72
commit e5636a322c
2 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
packages/core/schematics/test/undecorated_classes_with_di_migration_spec.ts
View File

@ -32,7 +32,6 @@ describe('Undecorated classes with DI migration', () => {
compilerOptions: {
lib: ['es2015'],
},
angularCompilerOptions: {enableIvy: false}
}));
writeFile('/angular.json', JSON.stringify({
projects: {t: {architect: {build: {options: {tsConfig: './tsconfig.json'}}}}}