cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: rename annotations to metadata

Browse Source 
BREAKING CHANGE (maybe)

Well as long as our customers use public API this should not be a
breaking change, but we have changed import structure as well as
internal names, so it could be breaking.

import:
  angular2/annotations => angular2/metadata

Classes:
  *Annotations => *Metadata
  renderer.DirectiveMetadata => renderer.RendererDirectiveMetadata
  renderer.ElementBinder => renderer.RendererElementBinder
  impl.Directive => impl.DirectiveMetadata
  impl.Component => impl.ComponentMetadata
  impl.View => impl.ViewMetadata

Closes #3660
This commit is contained in:
Misko Hevery
2015-08-14 10:03:45 -07:00
committed by Miško Hevery
parent 5e6317fecc
commit ea6673947c
172 changed files with 1287 additions and 1173 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
modules_dart/analyzer_plugin/lib/src/tasks.dart
View File

@ -8,11 +8,11 @@ import 'package:analyzer/task/model.dart';
import 'package:angular2/src/render/api.dart';
import 'package:angular2/src/transform/common/directive_metadata_reader.dart';
/// The [DirectiveMetadata]s of a [LibrarySpecificUnit].
final ListResultDescriptor<DirectiveMetadata> DIRECTIVES =
new ListResultDescriptor<DirectiveMetadata>('ANGULAR2_DIRECTIVES', null);
/// The [RenderDirectiveMetadata]s of a [LibrarySpecificUnit].
final ListResultDescriptor<RenderDirectiveMetadata> DIRECTIVES =
new ListResultDescriptor<RenderDirectiveMetadata>('ANGULAR2_DIRECTIVES', null);
/// A task that builds [DirectiveMetadata]s for directive classes.
/// A task that builds [RenderDirectiveMetadata]s for directive classes.
class BuildUnitDirectivesTask extends SourceBasedAnalysisTask {
static const String UNIT_INPUT = 'UNIT_INPUT';
@ -29,10 +29,10 @@ class BuildUnitDirectivesTask extends SourceBasedAnalysisTask {
@override
void internalPerform() {
CompilationUnit unit = getRequiredInput(UNIT_INPUT);
List<DirectiveMetadata> metaList = <DirectiveMetadata>[];
List<RenderDirectiveMetadata> metaList = <RenderDirectiveMetadata>[];
for (CompilationUnitMember unitMember in unit.declarations) {
if (unitMember is ClassDeclaration) {
DirectiveMetadata meta = readDirectiveMetadata(unitMember.metadata);
RenderDirectiveMetadata meta = readDirectiveMetadata(unitMember.metadata);
if (meta != null) {
metaList.add(meta);
}

10
modules_dart/analyzer_plugin/test/tasks_test.server.spec.dart
View File

@ -34,7 +34,7 @@ class BuildUnitDirectivesTaskTest extends _AbstractDartTaskTest {
void test_Component() {
_addAngularSources();
Source source = _newSource('/test.dart', r'''
import '/angular2/annotations.dart';
import '/angular2/metadata.dart';
@Component(selector: 'comp-a')
class ComponentA {
@ -57,7 +57,7 @@ class ComponentB {
void test_Directive() {
_addAngularSources();
Source source = _newSource('/test.dart', r'''
import '/angular2/annotations.dart';
import '/angular2/metadata.dart';
@Directive(selector: 'deco-a')
class ComponentA {
@ -78,12 +78,12 @@ class ComponentB {
}
void _addAngularSources() {
_newSource('/angular2/annotations.dart', r'''
library angular2.src.core.annotations.annotations;
_newSource('/angular2/metadata.dart', r'''
library angular2.src.core.metadata;
abstract class Directive {
final String selector;
final dynamic properties;
final dynamic properties;
final dynamic hostListeners;
final List lifecycle;
const Directive({selector, properties, hostListeners, lifecycle})