cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(di): changed InstantiationError to print the original stack

Browse Source
This commit is contained in:
vsavkin
2015-06-27 20:01:05 -07:00
parent 56245c6aa2
commit eb0fd7967c
3 changed files with 15 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
modules/angular2/test/core/compiler/integration_dart_spec.dart
View File

@ -55,8 +55,7 @@ main() {
});
describe('Error handling', () {
//TODO: vsavkin reenable this test after merging DI and EI
xit('should preserve Error stack traces thrown from components', inject([
it('should preserve Error stack traces thrown from components', inject([
TestComponentBuilder,
AsyncTestCompleter
], (tb, async) {
@ -65,13 +64,13 @@ main() {
directives: [ThrowingComponent]))
.createAsync(Dummy).catchError((e, stack) {
expect(stack.toString().split('\n')[0]).toEqual(e.message);
expect(e.message).toContain("MockException");
expect(e.message).toContain("functionThatThrows");
async.done();
});
}));
//TODO: vsavkin reenable this test after merging DI and EI
xit('should preserve non-Error stack traces thrown from components', inject([
it('should preserve non-Error stack traces thrown from components', inject([
TestComponentBuilder,
AsyncTestCompleter
], (tb, async) {
@ -80,7 +79,8 @@ main() {
directives: [ThrowingComponent2]))
.createAsync(Dummy).catchError((e, stack) {
expect(stack.toString().split('\n')[0]).toEqual(e.message);
expect(e.message).toContain("NonError");
expect(e.message).toContain("functionThatThrows");
async.done();
});
}));