cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(compiler): Generates function expressions as returning any (#9980)

Browse Source 
Function expressions are used in an expression context so untyped
function expressions should have any as the result type.

Fixes: #9877
This commit is contained in:
Chuck Jazdzewski
2016-07-11 17:19:38 -07:00
committed by GitHub
parent d1a3e3aff1
commit eb5763c23f
3 changed files with 22 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/@angular/compiler/src/output/ts_emitter.ts
View File

@ -170,7 +170,7 @@ class _TsEmitterVisitor extends AbstractEmitterVisitor implements o.TypeVisitor
ctx.print(`(`);
this._visitParams(ast.params, ctx);
ctx.print(`):`);
this.visitType(ast.type, ctx, 'void');
this.visitType(ast.type, ctx);
ctx.println(` => {`);
ctx.incIndent();
this.visitAllStatements(ast.statements, ctx);

4
modules/@angular/compiler/test/output/ts_emitter_spec.ts
View File

@ -143,11 +143,11 @@ export function main() {
});
it('should support function expressions', () => {
expect(emitStmt(o.fn([], []).toStmt())).toEqual(['():void => {', '};'].join('\n'));
expect(emitStmt(o.fn([], []).toStmt())).toEqual(['():any => {', '};'].join('\n'));
expect(emitStmt(o.fn([], [new o.ReturnStatement(o.literal(1))], o.INT_TYPE).toStmt()))
.toEqual(['():number => {', ' return 1;\n};'].join('\n'));
expect(emitStmt(o.fn([new o.FnParam('param1', o.INT_TYPE)], []).toStmt())).toEqual([
'(param1:number):void => {', '};'
'(param1:number):any => {', '};'
].join('\n'));
});