cargdev/angular
1
0
Fork 0
Code Issues 8 Pull Requests Actions Packages Projects Releases Wiki Activity

build(docs-infra): make type-checking stricter by enabling noImplicitAny (#29926)

Browse Source 
PR Close #29926
This commit is contained in:
George Kalpakas
2019-04-24 15:27:24 +03:00
committed by Andrew Kushnir
parent 2002db28ff
commit eb85c8a742
16 changed files with 47 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
aio/src/app/app.component.spec.ts
View File

@ -652,11 +652,11 @@ describe('AppComponent', () => {
component.tocMaxHeight = '100';
fixture.detectChanges();
expect(tocContainer!.style['max-height']).toBe('100px');
expect(tocContainer!.style.maxHeight).toBe('100px');
component.tocMaxHeight = '200';
fixture.detectChanges();
expect(tocContainer!.style['max-height']).toBe('200px');
expect(tocContainer!.style.maxHeight).toBe('200px');
});
it('should restrain scrolling inside the ToC container', () => {

4
aio/src/app/custom-elements/code/code-tabs.component.ts
View File

@ -1,5 +1,5 @@
/* tslint:disable component-selector */
import { Component, AfterViewInit, ViewChild, Input, ViewChildren, QueryList, OnInit } from '@angular/core';
import { AfterViewInit, Component, ElementRef, Input, OnInit, QueryList, ViewChild, ViewChildren } from '@angular/core';
import { CodeComponent } from './code.component';
export interface TabInfo {
@ -48,7 +48,7 @@ export class CodeTabsComponent implements OnInit, AfterViewInit {
@Input() linenums: string;
@ViewChild('content', { static: true }) content;
@ViewChild('content', { static: true }) content: ElementRef;
@ViewChildren(CodeComponent) codeComponents: QueryList<CodeComponent>;

6
aio/src/app/custom-elements/elements-loader.spec.ts
View File

@ -249,7 +249,7 @@ class FakeComponentFactory extends ComponentFactory<any> {
}
class FakeComponentFactoryResolver extends ComponentFactoryResolver {
constructor(private modulePath) { super(); }
constructor(private modulePath: string) { super(); }
resolveComponentFactory(component: Type<any>): ComponentFactory<any> {
return new FakeComponentFactory(this.modulePath);
@ -261,7 +261,7 @@ class FakeModuleRef extends NgModuleRef<WithCustomElementComponent> {
componentFactoryResolver = new FakeComponentFactoryResolver(this.modulePath);
instance: WithCustomElementComponent = new FakeCustomElementModule();
constructor(private modulePath) {
constructor(private modulePath: string) {
super();
this.injector.get.and.returnValue(this.componentFactoryResolver);
@ -275,7 +275,7 @@ class FakeModuleFactory extends NgModuleFactory<any> {
moduleType: Type<any>;
moduleRefToCreate = new FakeModuleRef(this.modulePath);
constructor(private modulePath) { super(); }
constructor(private modulePath: string) { super(); }
create(parentInjector: Injector | null): NgModuleRef<any> {
return this.moduleRefToCreate;

2
aio/src/app/shared/custom-icon-registry.ts
View File

@ -41,7 +41,7 @@ const DEFAULT_NS = '$$default';
export class CustomIconRegistry extends MatIconRegistry {
private preloadedSvgElements: SvgIconMap = {[DEFAULT_NS]: {}};
constructor(http: HttpClient, sanitizer: DomSanitizer, @Optional() @Inject(DOCUMENT) document,
constructor(http: HttpClient, sanitizer: DomSanitizer, @Optional() @Inject(DOCUMENT) document: Document,
@Inject(SVG_ICONS) svgIcons: SvgIconInfo[]) {
super(http, sanitizer, document);
this.loadSvgElements(svgIcons);