cargdev/angular
1
0
Fork 0
Code Issues 13 Pull Requests Actions Packages Projects Releases Wiki Activity

build(docs-infra): make type-checking stricter by enabling noImplicitAny (#29926)

Browse Source 
PR Close #29926
This commit is contained in:
George Kalpakas
2019-04-24 15:27:24 +03:00
committed by Andrew Kushnir
parent 2002db28ff
commit eb85c8a742
16 changed files with 47 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
aio/tests/e2e/src/api.po.ts
View File

@ -28,15 +28,15 @@ export class ApiPage extends SitePage {
return element.all(by.css(selector)).map<string>(item => item && item.getText());
}
getOverview(docType) {
getOverview(docType: string) {
return element(by.css(`.${docType}-overview`));
}
getSection(cls) {
getSection(cls: string) {
return element(by.css(`section.${cls}`));
}
getBadge(cls) {
getBadge(cls: string) {
return element(by.css('.api-status-label.' + cls));
}
}

6
aio/tests/e2e/src/app.po.ts
View File

@ -33,12 +33,12 @@ export class SitePage {
const script = `return arguments[0].parentNode.querySelector('${targetSelector}');`;
return element(() => browser.executeScript(script, heading));
}
getTopMenuLink(path) { return element(by.css(`aio-top-menu a[href="${path}"]`)); }
getTopMenuLink(path: string) { return element(by.css(`aio-top-menu a[href="${path}"]`)); }
ga() { return browser.executeScript('return window["ga"].q') as promise.Promise<any[][]>; }
locationPath() { return browser.executeScript('return document.location.pathname') as promise.Promise<string>; }
navigateTo(pageUrl) {
navigateTo(pageUrl: string) {
// Navigate to the page, disable animations, and wait for Angular.
return browser.get('/' + pageUrl)
.then(() => browser.executeScript('document.body.classList.add(\'no-animations\')'))
@ -49,7 +49,7 @@ export class SitePage {
return this.docViewer.getText();
}
getInnerHtml(elementFinder) {
getInnerHtml(elementFinder: ElementFinder) {
// `getInnerHtml` was removed from webDriver and this is the workaround.
// See https://github.com/angular/protractor/blob/master/CHANGELOG.md#breaking-changes
return browser.executeScript('return arguments[0].innerHTML;', elementFinder);

14
aio/tests/e2e/src/onerror.e2e-spec.ts
View File

@ -53,7 +53,7 @@ ZoneDelegate.prototype.invokeTask@https://example.com/packages/zone.js@0.8.18/di
forkInnerZoneWithAngularBehavior/zone._inner<.onInvokeTask@https://example.com/packages/@angular/core@5.0.0/bundles/core.umd.js:4656:24
ZoneDelegate.prototype.invokeTask@https://example.com/packages/zone.js@0.8.18/dist/zone.js:424:17
Zone.prototype.runTask@https://example.com/packages/zone.js@0.8.18/dist/zone.js:192:28
drainMicroTaskQueue@https://example.com/packages/zone.js@0.8.18/dist/zone.js:602:25` });
drainMicroTaskQueue@https://example.com/packages/zone.js@0.8.18/dist/zone.js:602:25` } as Error);
expect(message).toEqual(`something terrible has happened. oh no. oh no.
AppComponent@app.component.ts:31:29
@ -80,7 +80,7 @@ createDirectiveInstance@core.umd.j`);
onInvokeTask
runTask
drainMicroTaskQueue
promiseReactionJob@[native code]` });
promiseReactionJob@[native code]` } as Error);
expect(message).toEqual(`something terrible has happened. oh no. oh no.
AppComponent
@ -104,7 +104,7 @@ cr`);
at Object.debugCreateRootView [as createRootView] (https://example.com/packages/@angular/core@5.0.0/bundles/core.umd.js:14079:12)
at ComponentFactory_.create (https://example.com/packages/@angular/core@5.0.0/bundles/core.umd.js:10998:46)
at ComponentFactoryBoundToModule.create (https://example.com/packages/@angular/core@5.0.0/bundles/core.umd.js:3958:29)
at ApplicationRef.bootstrap (https://example.com/packages/@angular/core@5.0.0/bundles/core.umd.js:5769:57)` });
at ApplicationRef.bootstrap (https://example.com/packages/@angular/core@5.0.0/bundles/core.umd.js:5769:57)` } as Error);
expect(message).toEqual(`something terrible has happened. oh no. oh no.
new AppComponent@app.component.ts:31:29
@ -124,7 +124,7 @@ createDirectiveInstance@core.u`);
at Object.debugCreateRootView [as createRootView] (https://example.com/packages/@angular/core@5.0.0/bundles/core.umd.js:14079:12)
at ComponentFactory_.create (https://example.com/packages/@angular/core@5.0.0/bundles/core.umd.js:10998:46)
at ComponentFactoryBoundToModule.create (https://example.com/packages/@angular/core@5.0.0/bundles/core.umd.js:3958:29)
at ApplicationRef.bootstrap (https://example.com/packages/@angular/core@5.0.0/bundles/core.umd.js:5769:57)` });
at ApplicationRef.bootstrap (https://example.com/packages/@angular/core@5.0.0/bundles/core.umd.js:5769:57)` } as Error);
expect(message).toEqual(`something terrible has happened. oh no. oh no.
new AppComponent@app.component.ts:31:29
@ -156,7 +156,7 @@ ZoneDelegate.prototype.invokeTask@https://example.com/packages/zone.js@0.8.18/di
onInvokeTask@https://example.com/packages/@angular/core@5.0.0/bundles/core.umd.js:4656:24
ZoneDelegate.prototype.invokeTask@https://example.com/packages/zone.js@0.8.18/dist/zone.js:424:17
Zone.prototype.runTask@https://example.com/packages/zone.js@0.8.18/dist/zone.js:192:28
drainMicroTaskQueue@https://example.com/packages/zone.js@0.8.18/dist/zone.js:602:25` });
drainMicroTaskQueue@https://example.com/packages/zone.js@0.8.18/dist/zone.js:602:25` } as Error);
expect(message).toEqual(`something terrible has happened. oh no. oh no.
AppComponent@app.component.ts:31:29
@ -176,7 +176,7 @@ createDirectiveInstance@core.umd.j`);
at debugCreateRootView (eval code:14079:5)
at ComponentFactory_.prototype.create (eval code:10998:9)
at ComponentFactoryBoundToModule.prototype.create (eval code:3958:9)
at ApplicationRef.prototype.bootstrap (eval code:5769:9)` });
at ApplicationRef.prototype.bootstrap (eval code:5769:9)` } as Error);
expect(message).toEqual(`something terrible has happened. oh no. oh no.
AppComponent@???:31:21
@ -185,7 +185,7 @@ createDirectiveInstance@???:12049:5
createViewNodes@???`);
});
async function callOnError(message, url, line, column, error) {
async function callOnError(message: string, url?: string, line?: number, column?: number, error?: Error) {
await browser.executeScript(function() {
// reset the ga queue
(window as any).ga.q.length = 0;

2
aio/tests/e2e/src/search.e2e-spec.ts
View File

@ -1,7 +1,7 @@
import { SitePage } from './app.po';
describe('site search', () => {
let page;
let page: SitePage;
beforeEach(() => {
page = new SitePage();