cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(ivy): run compiler compliance tests without rebuilding core,common (#25248)

Browse Source 
Previously the compiler compliance tests ran and built test code with
real dependencies on @angular/core and @angular/common. This meant that
any changes to the compiler would result in long rebuild processes
for tests to rerun.

This change removes those dependencies and causes test code to be built
against the fake_core stub of @angular/core that the ngtsc tests use.
This change also removes the dependency on @angular/common entirely, as
locality means it's possible to reference *ngIf without needing to link
to an implementation.

PR Close #25248
This commit is contained in:
Alex Rickabaugh
2018-08-01 09:52:34 +02:00
committed by Kara Erickson
parent afa6b9e794
commit eb999300d9
13 changed files with 48 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/compiler-cli/test/compliance/r3_compiler_compliance_spec.ts
View File

@ -17,9 +17,9 @@ import {compile, expectEmit} from './mock_compile';
describe('compiler compliance', () => {
const angularFiles = setup({
compileAngular: true,
compileAngular: false,
compileAnimations: false,
compileCommon: true,
compileFakeCore: true,
});
describe('elements', () => {
@ -1287,7 +1287,6 @@ describe('compiler compliance', () => {
app: {
'spec.ts': `
import {Component, NgModule} from '@angular/core';
import {CommonModule} from '@angular/common';
@Component({
selector: 'my-component',
@ -1301,7 +1300,7 @@ describe('compiler compliance', () => {
})
export class MyComponent {}
@NgModule({declarations: [MyComponent], imports: [CommonModule]})
@NgModule({declarations: [MyComponent]})
export class MyModule {}
`
}