cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(compiler): don’t always compile .ngfactory.ts files by default

Browse Source 
This puts the behavior introduced in 573b8611bc behind the new flag
`alwaysCompileGeneratedCode` to not break users that might have relied
on this behavior.
This commit is contained in:
Tobias Bosch
2017-06-12 14:10:08 -07:00
committed by Alex Rickabaugh
parent 6ca46929fa
commit ed73d4f3ac
5 changed files with 51 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/compiler-cli/integrationtest/tsconfig-build.json
View File

@ -4,7 +4,8 @@
// in the same source directory with your code.
"genDir": ".",
"debug": true,
"enableSummariesForJit": true
"enableSummariesForJit": true,
"alwaysCompileGeneratedCode": true
},
"compilerOptions": {

40
packages/compiler-cli/test/main_spec.ts
View File

@ -199,10 +199,40 @@ describe('compiler-cli', () => {
});
describe('compile ngfactory files', () => {
it('should only compile ngfactory files that are referenced by root files by default',
(done) => {
writeConfig(`{
"extends": "./tsconfig-base.json",
"files": ["mymodule.ts"]
}`);
write('mymodule.ts', `
import {CommonModule} from '@angular/common';
import {NgModule} from '@angular/core';
@NgModule({
imports: [CommonModule]
})
export class MyModule {}
`);
main({p: basePath})
.then((exitCode) => {
expect(exitCode).toEqual(0);
expect(fs.existsSync(path.resolve(outDir, 'mymodule.ngfactory.js'))).toBe(false);
done();
})
.catch(e => done.fail(e));
});
it('should report errors for ngfactory files that are not referenced by root files', (done) => {
writeConfig(`{
"extends": "./tsconfig-base.json",
"files": ["mymodule.ts"]
"files": ["mymodule.ts"],
"angularCompilerOptions": {
"alwaysCompileGeneratedCode": true
}
}`);
write('mymodule.ts', `
import {NgModule, Component} from '@angular/core';
@ -235,7 +265,10 @@ describe('compiler-cli', () => {
it('should compile ngfactory files that are not referenced by root files', (done) => {
writeConfig(`{
"extends": "./tsconfig-base.json",
"files": ["mymodule.ts"]
"files": ["mymodule.ts"],
"angularCompilerOptions": {
"alwaysCompileGeneratedCode": true
}
}`);
write('mymodule.ts', `
import {CommonModule} from '@angular/common';
@ -289,7 +322,8 @@ describe('compiler-cli', () => {
"extends": "./tsconfig-base.json",
"files": ["mymodule.ts"],
"angularCompilerOptions": {
"enableSummariesForJit": true
"enableSummariesForJit": true,
"alwaysCompileGeneratedCode": true
}
}`);
write('mymodule.ts', `