cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ivy): ngtsc - do not wrap arguments unnecessarily (#30349)

Browse Source 
Previously we defensively wrapped expressions in case they ran afoul of
precedence rules. For example, it would be easy to create the TS AST structure
Call(Ternary(a, b, c)), but might result in printed code of:

```
a ? b : c()
```

Whereas the actual structure we meant to generate is:

```
(a ? b : c)()
```

However the TypeScript renderer appears to be clever enough to provide
parenthesis as necessary.

This commit removes these defensive paraenthesis in the cases of binary
and ternary operations.

FW-1273

PR Close #30349
This commit is contained in:
Pete Bacon Darwin
2019-05-09 11:23:30 +01:00
committed by Jason Aden
parent 0937062a64
commit eda09e69ea
6 changed files with 48 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/compiler-cli/test/compliance/r3_view_compiler_i18n_spec.ts
View File

@ -476,7 +476,7 @@ describe('i18n support in the view compiler', () => {
$r3$.Δselect(3);
$r3$.Δi18nExp($r3$.Δbind(ctx.valueA));
$r3$.Δi18nExp($r3$.Δbind(ctx.valueB));
$r3$.Δi18nExp($r3$.Δbind((ctx.valueA + ctx.valueB)));
$r3$.Δi18nExp($r3$.Δbind(ctx.valueA + ctx.valueB));
$r3$.Δi18nExp($r3$.Δbind(ctx.valueC));
$r3$.Δi18nApply(4);
}
@ -705,7 +705,7 @@ describe('i18n support in the view compiler', () => {
$r3$.Δselect(3);
$r3$.Δi18nExp($r3$.Δbind(ctx.valueA));
$r3$.Δi18nExp($r3$.Δbind(ctx.valueB));
$r3$.Δi18nExp($r3$.Δbind((ctx.valueA + ctx.valueB)));
$r3$.Δi18nExp($r3$.Δbind(ctx.valueA + ctx.valueB));
$r3$.Δi18nExp($r3$.Δbind(ctx.valueC));
$r3$.Δi18nApply(4);
}
@ -1065,7 +1065,7 @@ describe('i18n support in the view compiler', () => {
if (rf & 2) {
$r3$.Δselect(1);
$r3$.Δi18nExp($r3$.Δbind($r3$.ΔpipeBind1(2, 2, ctx.valueA)));
$r3$.Δi18nExp($r3$.Δbind(((ctx.valueA == null) ? null : ((ctx.valueA.a == null) ? null : ctx.valueA.a.b))));
$r3$.Δi18nExp($r3$.Δbind(ctx.valueA == null ? null : ctx.valueA.a == null ? null : ctx.valueA.a.b));
$r3$.Δi18nApply(1);
}
}
@ -1141,7 +1141,7 @@ describe('i18n support in the view compiler', () => {
$r3$.Δi18nExp($r3$.Δbind($r3$.ΔpipeBind1(4, 3, ctx.two)));
$r3$.Δi18nApply(3);
$r3$.Δselect(6);
$r3$.Δi18nExp($r3$.Δbind(((ctx.three + ctx.four) + ctx.five)));
$r3$.Δi18nExp($r3$.Δbind(ctx.three + ctx.four + ctx.five));
$r3$.Δi18nApply(6);
}
}
@ -1609,7 +1609,7 @@ describe('i18n support in the view compiler', () => {
if (rf & 2) {
const $ctx_r1$ = $r3$.ΔnextContext();
$r3$.Δselect(0);
$r3$.Δi18nExp($r3$.Δbind(($ctx_r1$.valueE + $ctx_r1$.valueF)));
$r3$.Δi18nExp($r3$.Δbind($ctx_r1$.valueE + $ctx_r1$.valueF));
$r3$.Δi18nExp($r3$.Δbind($r3$.ΔpipeBind1(3, 2, $ctx_r1$.valueG)));
$r3$.Δi18nApply(0);
}
@ -2765,7 +2765,7 @@ describe('i18n support in the view compiler', () => {
if (rf & 2) {
$r3$.Δselect(1);
$r3$.Δi18nExp($r3$.Δbind(ctx.gender));
$r3$.Δi18nExp($r3$.Δbind(((ctx.ageA + ctx.ageB) + ctx.ageC)));
$r3$.Δi18nExp($r3$.Δbind(ctx.ageA + ctx.ageB + ctx.ageC));
$r3$.Δi18nApply(1);
}
}