cargdev/angular
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

build: fix web_worker playground examples using external resources (#28562)

Browse Source 
The `web_workers/images` example is not being tested by any e2e
spec and therefore it's technically not necessary to fix that it uses
external resources, though in order to ensure that the Bazel builds
are hermetic and that we can eventually add e2e specs for the
web_worker/image example, we should avoid any use of external
resources.

We remove the `web-animations` polyfill in the `web_workers/animations`
example because we should try to vendor as few as possible deps. Also
the animations API is already supported by browsers we run the e2e tests
against (note here: `web_workers/animations` is currently also disabled)

PR Close #28562
This commit is contained in:
Paul Gschwendtner
2019-02-06 12:33:17 +01:00
committed by Miško Hevery
parent b5e36eaa3e
commit edda94edfa
12 changed files with 277 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/playground/src/web_workers/animations/index.html
View File

@ -7,7 +7,5 @@
<animation-app>
Loading...
</animation-app>
<script src="https://cdnjs.cloudflare.com/ajax/libs/web-animations/2.2.2/web-animations-next-lite.min.js"></script>
</body>
</html>

10
modules/playground/src/web_workers/images/BUILD.bazel
View File

@ -19,6 +19,8 @@ ng_module(
ts_devserver(
name = "devserver",
# Workaround for: https://github.com/bazelbuild/rules_typescript/issues/409
additional_root_paths = ["angular"],
data = [
"//modules/playground/src/web_workers:worker-config",
"@ngdeps//node_modules/base64-js:base64js.min.js",
@ -30,6 +32,12 @@ ts_devserver(
index_html = "index.html",
port = 4200,
scripts = ["@ngdeps//node_modules/tslib:tslib.js"],
static_files = ["@ngdeps//node_modules/zone.js:dist/zone.js"],
static_files = [
"@ngdeps//node_modules/zone.js:dist/zone.js",
"@ngdeps//node_modules/materialize-css:dist/js/materialize.min.js",
"@ngdeps//node_modules/materialize-css:dist/css/materialize.min.css",
"@ngdeps//node_modules/jquery:dist/jquery.min.js",
"//third_party/github.com/google/material-design-icons",
],
deps = [":images"],
)

10
modules/playground/src/web_workers/images/index.html
View File

@ -1,16 +1,8 @@
<html>
<head>
<link rel="stylesheet" href="image_demo.css" />
<link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet">
</head>
<body>
<image-demo>
</image-demo>
<!-- Compiled and minified CSS -->
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/materialize/0.97.0/css/materialize.min.css">
<!-- Compiled and minified JavaScript -->
<script type="text/javascript" src="https://code.jquery.com/jquery-2.1.1.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/materialize/0.97.0/js/materialize.min.js"></script>
<image-demo></image-demo>
</body>
</html>

11
modules/playground/src/web_workers/images/single_thread.html
View File

@ -1,18 +1,17 @@
<html>
<head>
<link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet">
<link href="angular/third_party/github.com/google/material-design-icons/material-icons.css"
rel="stylesheet">
<link rel="stylesheet" href="image_demo.css" />
</head>
<body>
<image-demo>
</image-demo>
<script src="../../bootstrap.js"></script>
<!-- Compiled and minified CSS -->
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/materialize/0.97.0/css/materialize.min.css">
<link rel="stylesheet" href="angular/third_party/cdnjs.cloudflare.com/materialize/materialize.min.css">
<!-- Compiled and minified JavaScript -->
<script type="text/javascript" src="https://code.jquery.com/jquery-2.1.1.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/materialize/0.97.0/js/materialize.min.js"></script>
<script type="text/javascript" src="angular/third_party/code.jquery.com/jquery-2.1.1.min.js"></script>
<script src="angular/third_party/cdnjs.cloudflare.com/materialize/materialize.min.js"></script>
</body>
</html>

3
modules/playground/src/web_workers/todo/index_web_socket.html
View File

@ -6,8 +6,5 @@
<todo-app>
Loading...
</todo-app>
<script src="../bootstrap.js"></script>
</body>
</html>