cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

build: update jasmine to 3.5 (#34625)

Browse Source 
1. update jasmine to 3.5
2. update @types/jasmine to 3.5
3. update @types/jasminewd2 to 2.0.8

Also fix several cases, the new jasmine 3 will help to create test cases correctly,
such as in the `jasmine 2.x` version, the following case will pass

```
expect(1 == 2);
```

But in jsamine 3, the case will need to be

```
expect(1 == 2).toBeTrue();
```

PR Close #34625
This commit is contained in:
JiaLiPassion
2020-01-03 14:28:06 +09:00
committed by Kara Erickson
parent db4a448439
commit ef4736d052
29 changed files with 124 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/platform-browser/test/dom/events/hammer_gestures_spec.ts
View File

@ -25,7 +25,7 @@ import {HammerGestureConfig, HammerGesturesPlugin,} from '@angular/platform-brow
});
it('should implement addGlobalEventListener', () => {
spyOn(plugin, 'addEventListener').and.callFake(() => {});
spyOn(plugin, 'addEventListener').and.callFake(() => () => {});
expect(() => {
plugin.addGlobalEventListener('document', 'swipe', () => {});

2
packages/platform-browser/test/dom/events/key_events_spec.ts
View File

@ -62,7 +62,7 @@ import {KeyEventsPlugin} from '@angular/platform-browser/src/dom/events/key_even
it('should implement addGlobalEventListener', () => {
const plugin = new KeyEventsPlugin(document);
spyOn(plugin, 'addEventListener').and.callFake(() => {});
spyOn(plugin, 'addEventListener').and.callFake(() => () => {});
expect(() => plugin.addGlobalEventListener('window', 'keyup.control.esc', () => {}))
.not.toThrowError();