cargdev/angular
1
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ivy): don't detect changes on detached child embedded views (#34846)

Browse Source 
Fixes Ivy detecting changes inside child embedded views, even though they're detached.

Note that there's on subtlety here: I made the changes inside `refreshDynamicEmbeddedViews` rather than `refreshView`, because we support detecting changes on a detached view (evidenced by a couple of unit tests), but only if it's triggered directly from the view's `ChangeDetectorRef`, however we shouldn't be detecting changes in the detached child view when something happens in the parent.

Fixes #34816.

PR Close #34846
This commit is contained in:
Kristiyan Kostadinov
2020-01-23 13:20:05 +01:00
committed by Andrew Kushnir
parent ed24100976
commit ef95da6d3b
3 changed files with 113 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
integration/_payload-limits.json
View File

@ -3,7 +3,7 @@
"master": {
"uncompressed": {
"runtime-es2015": 1485,
"main-es2015": 141476,
"main-es2015": 141985,
"polyfills-es2015": 36808
}
}
@ -21,7 +21,7 @@
"master": {
"uncompressed": {
"runtime-es2015": 1485,
"main-es2015": 147610,
"main-es2015": 148115,
"polyfills-es2015": 36808
}
}