cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(bazel): protractor rule does not run spec files with underscore (#28022)

Browse Source 
There are various e2e tests with the `_spec.ts` suffix in the Angular project. Currently the protractor Bazel rule does not pick up these files and just ignores them. Since underscore is commonly used, we should support this.

Needed for the conversion fo the `examples` to Bazel.

PR Close #28022
This commit is contained in:
Paul Gschwendtner 2019-01-09 19:44:48 +01:00 committed by Andrew Kushnir
parent 2e0c58ec3e
commit f05c5f82c8
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/bazel/src/protractor/protractor.conf.js
View File

@ -88,7 +88,8 @@ if (onPreparePath) {
// ts_web_test_suite & rules_webtesting WEB_TEST_METADATA attributes // ts_web_test_suite & rules_webtesting WEB_TEST_METADATA attributes
setConf(conf, 'framework', 'jasmine2', 'is set to jasmine2'); setConf(conf, 'framework', 'jasmine2', 'is set to jasmine2');
const specs = [TMPL_specs].map(s => require.resolve(s)).filter(s => /\b(spec|test)\.js$/.test(s)); const specs =
[TMPL_specs].map(s => require.resolve(s)).filter(s => /(\b|_)(spec|test)\.js$/.test(s));
setConf(conf, 'specs', specs, 'are determined by the srcs and deps attribute'); setConf(conf, 'specs', specs, 'are determined by the srcs and deps attribute');