cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(compiler): don't convert undefined to null literals (#11503)

Browse Source 
Fixes #11493
This commit is contained in:
Pawel Kozlowski
2016-11-04 18:55:21 +01:00
committed by vikerman
parent 051d74802a
commit f0cdb428f5
5 changed files with 28 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
modules/@angular/compiler/src/output/abstract_emitter.ts
View File

@ -250,13 +250,11 @@ export abstract class AbstractEmitterVisitor implements o.StatementVisitor, o.Ex
ctx.print(`)`);
return null;
}
visitLiteralExpr(ast: o.LiteralExpr, ctx: EmitterVisitorContext, absentValue: string = 'null'):
any {
var value = ast.value;
visitLiteralExpr(ast: o.LiteralExpr, ctx: EmitterVisitorContext): any {
const value = ast.value;
if (typeof value === 'string') {
ctx.print(escapeIdentifier(value, this._escapeDollarInStrings));
} else if (isBlank(value)) {
ctx.print(absentValue);
} else {
ctx.print(`${value}`);
}

7
modules/@angular/compiler/src/output/ts_emitter.ts
View File

@ -68,7 +68,12 @@ class _TsEmitterVisitor extends AbstractEmitterVisitor implements o.TypeVisitor
}
visitLiteralExpr(ast: o.LiteralExpr, ctx: EmitterVisitorContext): any {
super.visitLiteralExpr(ast, ctx, '(null as any)');
const value = ast.value;
if (isBlank(value)) {
ctx.print(`(${value} as any)`);
return null;
}
return super.visitLiteralExpr(ast, ctx);
}