From f0f81f482e1511554cc2038b1e2b10294711d4cc Mon Sep 17 00:00:00 2001 From: Greg Magolan Date: Thu, 21 Feb 2019 10:57:56 -0800 Subject: [PATCH] build: added comments after review (#27721) PR Close #27721 --- BUILD.bazel | 2 ++ karma-js.conf.js | 3 +++ 2 files changed, 5 insertions(+) diff --git a/BUILD.bazel b/BUILD.bazel index fa47af6586..f9f73b000c 100644 --- a/BUILD.bazel +++ b/BUILD.bazel @@ -69,6 +69,8 @@ nodejs_binary( # "sauce-connect": "https://saucelabs.com/downloads/sc-4.5.3-linux.tar.gz". # On OSX or Windows you'll need to use the appropriate sauce-connect binary. # 3) run target with `yarn bazel test --config=saucelabs ` +# NOTE: --config=saucelabs is required as it makes the SAUCE_XXX environment variables available to +# the action. See /.bazelrc. karma_web_test( name = "test_web_all", tags = [ diff --git a/karma-js.conf.js b/karma-js.conf.js index f73adf9df0..4d07a2f369 100644 --- a/karma-js.conf.js +++ b/karma-js.conf.js @@ -145,6 +145,9 @@ module.exports = function(config) { browserNoActivityTimeout: 300000, } + // When running under Bazel with karma_web_test, SAUCE_TUNNEL_IDENTIFIER and KARMA_WEB_TEST_MODE + // will only be available when `--config=saucelabs` is set. See //:test_web_all target + // and /.bazelrc. if (process.env['SAUCE_TUNNEL_IDENTIFIER']) { console.log(`SAUCE_TUNNEL_IDENTIFIER: ${process.env.SAUCE_TUNNEL_IDENTIFIER}`);