From f1f04fa7829570a14eed774b981856ca91211319 Mon Sep 17 00:00:00 2001 From: Ward Bell Date: Thu, 27 Apr 2017 15:33:50 -0700 Subject: [PATCH] feat(aio): implement gkalpak review suggestions --- aio/src/app/embedded/toc/toc.component.html | 4 ++-- aio/src/app/embedded/toc/toc.component.ts | 4 ++-- aio/src/app/layout/doc-viewer/doc-viewer.component.ts | 2 +- aio/src/styles/2-modules/_toc.scss | 7 ------- 4 files changed, 5 insertions(+), 12 deletions(-) diff --git a/aio/src/app/embedded/toc/toc.component.html b/aio/src/app/embedded/toc/toc.component.html index 4255257827..9c869e1568 100644 --- a/aio/src/app/embedded/toc/toc.component.html +++ b/aio/src/app/embedded/toc/toc.component.html @@ -1,6 +1,6 @@
-
Contents
-
Contents
+
diff --git a/aio/src/app/embedded/toc/toc.component.ts b/aio/src/app/embedded/toc/toc.component.ts index 5785136181..ccf8e4dfd1 100644 --- a/aio/src/app/embedded/toc/toc.component.ts +++ b/aio/src/app/embedded/toc/toc.component.ts @@ -17,9 +17,9 @@ export class TocComponent implements OnInit { tocList: TocItem[]; constructor( - private elementRef: ElementRef, + elementRef: ElementRef, private tocService: TocService) { - const hostElement = this.elementRef.nativeElement; + const hostElement = elementRef.nativeElement; this.isEmbedded = hostElement.className.indexOf('embedded') !== -1; } diff --git a/aio/src/app/layout/doc-viewer/doc-viewer.component.ts b/aio/src/app/layout/doc-viewer/doc-viewer.component.ts index 504f3c3648..2f9a2c691a 100644 --- a/aio/src/app/layout/doc-viewer/doc-viewer.component.ts +++ b/aio/src/app/layout/doc-viewer/doc-viewer.component.ts @@ -97,7 +97,7 @@ export class DocViewerComponent implements DoCheck, OnDestroy { let title = ''; const titleEl = this.hostElement.querySelector('h1'); // Only create TOC for docs with an

title - // If you don't want a TOC, don't have an

+ // If you don't want a TOC, add "no-toc" class to

if (titleEl) { title = titleEl.innerText.trim(); if (!/(no-toc|notoc)/i.test(titleEl.className)) { diff --git a/aio/src/styles/2-modules/_toc.scss b/aio/src/styles/2-modules/_toc.scss index 4a091bf6dd..83fabc5b55 100644 --- a/aio/src/styles/2-modules/_toc.scss +++ b/aio/src/styles/2-modules/_toc.scss @@ -94,10 +94,3 @@ aio-toc > div { aio-toc > div.closed li.secondary { display: none; } - -@media screen and (max-width: 1200px) { - aio-toc.embedded:not(:empty) { - display: block; - margin: 20px 0 24px; - } -}