From f1ffa7a3671c9be6817378652e00e7e621d3ccac Mon Sep 17 00:00:00 2001 From: Greg Magolan Date: Mon, 24 Feb 2020 09:17:32 -0800 Subject: [PATCH] ci: move saucelabs_ivy & saucelabs_view_engine to the daily monitoring CircleCI workflow (#35516) PR Close #35516 --- .circleci/config.yml | 48 ++++++++++++++++++++------------------------ 1 file changed, 22 insertions(+), 26 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 8ceecc8029..39622ae245 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -343,7 +343,7 @@ jobs: path: dist/bin/packages/core/test/bundling/todo/bundle.min.js.br destination: core/todo/bundle.br - # NOTE: This is currently limited to master builds only. See the `default_workflow` configuration. + # NOTE: This is currently limited to master builds only. See the `monitoring` configuration. saucelabs_view_engine: executor: name: default-executor @@ -367,7 +367,7 @@ jobs: - notify_webhook_on_fail: webhook_url_env_var: SLACK_DEV_INFRA_CI_FAILURES_WEBHOOK_URL - # NOTE: This is currently limited to master builds only. See the `default_workflow` configuration. + # NOTE: This is currently limited to master builds only. See the `monitoring` configuration. saucelabs_ivy: executor: name: default-executor @@ -840,26 +840,6 @@ workflows: - legacy-unit-tests-saucelabs: requires: - setup - - saucelabs_ivy: - # Testing saucelabs via Bazel currently taking longer than the legacy saucelabs job as it - # each karma_web_test target is provisioning and tearing down browsers which is adding - # a lot of overhead. Running on master only to avoid wasting resources and slowing down - # CI for PRs. - # TODO: Run this job on all branches (including PRs) once karma_web_test targets can - # share provisioned browsers and we can remove the legacy saucelabs job. - <<: *only_on_master - requires: - - setup - - saucelabs_view_engine: - # Testing saucelabs via Bazel currently taking longer than the legacy saucelabs job as it - # each karma_web_test target is provisioning and tearing down browsers which is adding - # a lot of overhead. Running on master only to avoid wasting resources and slowing down - # CI for PRs. - # TODO: Run this job on all branches (including PRs) once karma_web_test targets can - # share provisioned browsers and we can remove the legacy saucelabs job. - <<: *only_on_master - requires: - - setup - test_aio: requires: - setup @@ -909,8 +889,6 @@ workflows: - test - test_ivy_aot - integration_test - - saucelabs_view_engine - - saucelabs_ivy # Only publish if `aio`/`docs` tests using the locally built Angular packages pass - test_aio_local - test_aio_local_viewengine @@ -942,7 +920,7 @@ workflows: requires: - test_ivy_aot - aio_monitoring: + monitoring: jobs: - setup - aio_monitoring_stable: @@ -951,8 +929,26 @@ workflows: - aio_monitoring_next: requires: - setup + - saucelabs_ivy: + # Testing saucelabs via Bazel currently taking longer than the legacy saucelabs job as it + # each karma_web_test target is provisioning and tearing down browsers which is adding + # a lot of overhead. Running once daily on master only to avoid wasting resources and + # slowing down CI for PRs. + # TODO: Run this job on all branches (including PRs) once karma_web_test targets can + # share provisioned browsers and we can remove the legacy saucelabs job. + requires: + - setup + - saucelabs_view_engine: + # Testing saucelabs via Bazel currently taking longer than the legacy saucelabs job as it + # each karma_web_test target is provisioning and tearing down browsers which is adding + # a lot of overhead. Running once daily on master only to avoid wasting resources and + # slowing down CI for PRs. + # TODO: Run this job on all branches (including PRs) once karma_web_test targets can + # share provisioned browsers and we can remove the legacy saucelabs job. + requires: + - setup triggers: - schedule: <<: *only_on_master - # Runs AIO monitoring jobs at 10:00AM every day. + # Runs monitoring jobs at 10:00AM every day. cron: "0 10 * * *"