test: update ts-api-guardian's strip_export_pattern to exclude Ivy instructions (#38224)
Previously the instructions were included in the golden files to monitor the frequency and rate of the instruction API changes for the purpose of understanding the stability of this API (as it was considered for becoming a public API and deployed to npm via generated code). This experiment has confirmed that the instruction API is not stable enough to be used as public API. We've since also came up with an alternative plan to compile libraries with the Ivy compiler for npm deployment and this plan does not rely on making Ivy instructions public. For these reasons, I'm removing the instructions from the golden files as it's no longer important to track them. The are three instructions that are still being included: `ɵɵdefineInjectable`, `ɵɵinject`, and `ɵɵInjectableDef`. These instructions are already generated by the VE compiler to support tree-shakable providers, and code depending on these instructions is already deployed to npm. For this reason we need to treat them as public api. This change also reduces the code review overhead, because changes to public api golden files now require multiple approvals. PR Close #38224
This commit is contained in:

committed by
Michael Prentice

parent
134aa72467
commit
f26f014ffc
@ -23,7 +23,8 @@ import {ClassProvider, ConstructorProvider, ExistingProvider, FactoryProvider, S
|
||||
* that the injectable does not belong to any scope.
|
||||
*
|
||||
* @codeGenApi
|
||||
* @publicApi This instruction has been emitted by ViewEngine for some time and is deployed to npm.
|
||||
* @publicApi The ViewEngine compiler emits code with this type for injectables. This code is
|
||||
* deployed to npm, and should be treated as public api.
|
||||
|
||||
*/
|
||||
export interface ɵɵInjectableDef<T> {
|
||||
|
Reference in New Issue
Block a user