cargdev/angular
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(ivy): rewrite flatten function to be more memory efficient (#30468)

Browse Source 
The `flatten` function used `concat` and `slice` which created a lot of intermediary
object allocations. Because `flatten` is used from query any benchmark which
used query would exhibit high minor GC counts.

PR Close #30468
This commit is contained in:
Miško Hevery
2019-05-14 15:55:46 -07:00
committed by Jason Aden
parent c9f5f3d802
commit f3c69e7f6b
4 changed files with 35 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
integration/side-effects/snapshots/core/esm2015.js
View File

@ -30,20 +30,16 @@ function getSymbolIterator() {
if ("undefined" === typeof ngI18nClosureMode) _global["ngI18nClosureMode"] = "undefined" !== typeof goog && "function" === typeof goog.getMsg;
function flatten(list, mapFn) {
const result = [];
let i = 0;
while (i < list.length) {
const item = list[i];
if (Array.isArray(item)) if (item.length > 0) {
list = item.concat(list.slice(i + 1));
i = 0;
} else i++; else {
result.push(mapFn ? mapFn(item) : item);
i++;
}
function flatten(list, dst) {
if (void 0 === dst) dst = list;
for (let i = 0; i < list.length; i++) {
let item = list[i];
if (Array.isArray(item)) {
if (dst === list) dst = list.slice(0, i);
flatten(item, dst);
} else if (dst !== list) dst.push(item);
}
return result;
return dst;
}
class EventEmitter extends Subject {