From f58f3dc07a5961f881c7ef993dd2acb65f8326f4 Mon Sep 17 00:00:00 2001 From: Alex Rickabaugh Date: Tue, 3 Jul 2018 14:09:56 -0700 Subject: [PATCH] fix(ivy): handle ReadKeyExpr code generation (#24862) This implements a missing expression type in ngtsc code generation: that of bracket access to an object property. PR Close #24862 --- packages/compiler-cli/src/ngtsc/transform/src/translator.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/compiler-cli/src/ngtsc/transform/src/translator.ts b/packages/compiler-cli/src/ngtsc/transform/src/translator.ts index c5e8f967cd..339778938f 100644 --- a/packages/compiler-cli/src/ngtsc/transform/src/translator.ts +++ b/packages/compiler-cli/src/ngtsc/transform/src/translator.ts @@ -237,8 +237,9 @@ class ExpressionTranslatorVisitor implements ExpressionVisitor, StatementVisitor return ts.createPropertyAccess(ast.receiver.visitExpression(this, context), ast.name); } - visitReadKeyExpr(ast: ReadKeyExpr, context: any): never { - throw new Error('Method not implemented.'); + visitReadKeyExpr(ast: ReadKeyExpr, context: any): ts.ElementAccessExpression { + return ts.createElementAccess( + ast.receiver.visitExpression(this, context), ast.index.visitExpression(this, context)); } visitLiteralArrayExpr(ast: LiteralArrayExpr, context: any): ts.ArrayLiteralExpression {