cargdev/angular
1
0
Fork 0
Code Issues 11 Pull Requests Actions Packages Projects Releases Wiki Activity

ci: set up golden file for typescript circular dependencies (#35647)

Browse Source 
Sets up a golden file for the TypeScript circular dependencies for
source files inside of the `packages/` folder.

Also sets up the appropriate Yarn shorthand scripts, and a codeowner
group that is soley responsible for verifying changes to the golden.

PR Close #35647
This commit is contained in:
Paul Gschwendtner
2020-02-24 12:08:24 +01:00
committed by Andrew Kushnir
parent b7138c1ec5
commit f5a5c36d3c
5 changed files with 5711 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
dev-infra/ts-circular-dependencies/index.ts
View File

@ -120,9 +120,17 @@ export function main(
chalk.yellow(` Fixed circular dependencies that need to be removed from the golden:`));
fixedCircularDeps.forEach(c => console.error(` • ${convertReferenceChainToString(c)}`));
console.info();
console.info(chalk.yellow(
` Please update the golden. The following command can be ` +
`run: yarn ts-circular-deps approve ${getRelativePath(baseDir, goldenFile)}.`));
// Print the command for updating the golden. Note that we hard-code the script name for
// approving default packages golden in `goldens/`. We cannot infer the script name passed to
// Yarn automatically since script are launched in a child process where `argv0` is different.
if (resolve(goldenFile) === resolve(projectDir, 'goldens/packages-circular-deps.json')) {
console.info(
chalk.yellow(` Please approve the new golden with: yarn ts-circular-deps:approve`));
} else {
console.info(chalk.yellow(
` Please update the golden. The following command can be ` +
`run: yarn ts-circular-deps approve ${getRelativePath(baseDir, goldenFile)}.`));
}
}
return 1;
}