From f7815cf96defa6b19fff482824c5997f03fd78ea Mon Sep 17 00:00:00 2001 From: Pete Bacon Darwin Date: Wed, 6 May 2020 22:22:08 +0100 Subject: [PATCH] test(compiler-cli): ensure reflection tests are not brittle to case-sensitivity (#36859) These tests were matching file-paths against what is retrieved from the TS compiler. But the TS compiler paths have been canonicalised, so the tests were brittle on case-insensitive file-systems. PR Close #36859 --- .../compiler-cli/src/ngtsc/reflection/test/ts_host_spec.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/compiler-cli/src/ngtsc/reflection/test/ts_host_spec.ts b/packages/compiler-cli/src/ngtsc/reflection/test/ts_host_spec.ts index 5210047cbe..e9830f2160 100644 --- a/packages/compiler-cli/src/ngtsc/reflection/test/ts_host_spec.ts +++ b/packages/compiler-cli/src/ngtsc/reflection/test/ts_host_spec.ts @@ -6,7 +6,7 @@ * found in the LICENSE file at https://angular.io/license */ import * as ts from 'typescript'; -import {absoluteFrom} from '../../file_system'; +import {absoluteFrom, getSourceFileOrError} from '../../file_system'; import {runInEachFileSystem} from '../../file_system/testing'; import {getDeclaration, makeProgram} from '../../testing'; import {CtorParameter} from '../src/host'; @@ -329,8 +329,8 @@ runInEachFileSystem(() => { } else if (directTargetDecl === null) { return fail('No declaration found for DirectTarget'); } - expect(targetDecl.node!.getSourceFile().fileName) - .toBe(_('/node_modules/absolute/index.ts')); + expect(targetDecl.node!.getSourceFile()) + .toBe(getSourceFileOrError(program, _('/node_modules/absolute/index.ts'))); expect(ts.isClassDeclaration(targetDecl.node!)).toBe(true); expect(directTargetDecl.viaModule).toBe('absolute'); expect(directTargetDecl.node).toBe(targetDecl.node);