cargdev/angular
1
0
Fork 0
Code Issues 4 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(compiler): always check summaries first before falling back to metadata from .d.ts files (#18788)

Browse Source 
PR Close #18788
This commit is contained in:
Tobias Bosch
2017-08-22 16:18:18 -07:00
committed by Miško Hevery
parent 0262e37301
commit f83b819bea
2 changed files with 22 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
packages/compiler/src/aot/static_symbol_resolver.ts
View File

@ -78,20 +78,22 @@ export class StaticSymbolResolver {
if (staticSymbol.members.length > 0) {
return this._resolveSymbolMembers(staticSymbol) !;
}
let result = this.resolvedSymbols.get(staticSymbol);
if (result) {
return result;
// Note: always ask for a summary first,
// as we might have read shallow metadata via a .d.ts file
// for the symbol.
const resultFromSummary = this._resolveSymbolFromSummary(staticSymbol) !;
if (resultFromSummary) {
return resultFromSummary;
}
result = this._resolveSymbolFromSummary(staticSymbol) !;
if (result) {
return result;
const resultFromCache = this.resolvedSymbols.get(staticSymbol);
if (resultFromCache) {
return resultFromCache;
}
// Note: Some users use libraries that were not compiled with ngc, i.e. they don't
// have summaries, only .d.ts files. So we always need to check both, the summary
// and metadata.
this._createSymbolsOf(staticSymbol.filePath);
result = this.resolvedSymbols.get(staticSymbol) !;
return result;
return this.resolvedSymbols.get(staticSymbol) !;
}
/**