cargdev/angular
1
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

build: remove references to tsc-wrapped (#19298)

Browse Source 
With this commit `ngc` is used instead of `tsc-wrapped` for
collecting metadata and tsickle rewriting and `tsc-wrapped`
is removed from the repository.

`@angular/tsc-wrapped@5` is now deprecated and is no longer
used, updated, or maintained as part as of Angular 5.x.x.

`@angular/tsc-wrapped@4` is still maintained and required by
Angular 4.x.x and will be maintained as long as 4.x.x is in
LTS.

PR Close #19298
This commit is contained in:
Chuck Jazdzewski
2017-09-20 09:54:47 -07:00
committed by Igor Minar
parent 4c73b52d5c
commit f96142cd7c
104 changed files with 336 additions and 6594 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tools/gulp-tasks/lint.js
View File

@ -16,9 +16,6 @@ module.exports = (gulp) => () => {
// Ignore node_modules directories
'!**/node_modules/**',
// Ignore TypeScript mocks because it's not managed by us
'!./tools/@angular/tsc-wrapped/test/typescript.mocks.ts',
// Ignore generated files due to lack of copyright header
// todo(alfaproject): make generated files lintable
'!**/*.d.ts',

2
tools/gulp-tasks/source-map-test.js
View File

@ -2,7 +2,7 @@ const fs = require('fs');
const path = require('path');
const sourceMapTest = require('../source-map-test');
const excludedPackages = ['bazel', 'tsc-wrapped', 'benchpress', 'compiler-cli', 'language-service'];
const excludedPackages = ['bazel', 'benchpress', 'compiler-cli', 'language-service'];
module.exports = (gulp) => () => {
const packageDir = path.resolve(process.cwd(), 'dist/packages-dist/');

12
tools/source-map-test/index.js
View File

@ -11,11 +11,12 @@ const PROPERTY_REGEX = /Object.defineProperty\((\S+)\.prototype, "(\S+)", {/g;
const METHOD_REGEX = /(\S+)\.prototype\.(\S+) = function \((\S*)\) {/g;
const GETTER_REGEX = /get_REGEX = function \((\S*)\) {/g;
const TYPE_COMMENT_REGEX = /\/\*\* @type {\?} \*\/ /g;
const AFTER_EQUALS_REGEX = /(.+)=(.*)/g;
const AFTER_EQUALS_REGEX = /([^=]+)=(.*)/g;
const EXPORT_REGEX = /export /g;
const TSLIB_REGEX = /tslib_\d\.__/g;
const STRIP_PREFIX_REGEX = /ɵ/g;
const STRIP_SUFFIX_REGEX = /([^$]+)(\$)+\d/g;
const SYNTHETIC_REGEX = /ɵ[0-9]/;
module.exports = function sourceMapTest(package) {
const mappings =
@ -23,8 +24,13 @@ module.exports = function sourceMapTest(package) {
console.log(`Analyzing ${mappings.length} mappings for ${package}...`);
const failures = mappings.filter(
mapping => { return cleanSource(mapping.sourceText) !== cleanGen(mapping.genText); });
const failures = mappings.filter(mapping => {
if (SYNTHETIC_REGEX.test(mapping.sourceText)) return false;
if (cleanSource(mapping.sourceText) !== cleanGen(mapping.genText)) {
console.log('source:', cleanSource(mapping.sourceText), 'gen:', cleanGen(mapping.genText))
}
return cleanSource(mapping.sourceText) !== cleanGen(mapping.genText);
});
logResults(failures);
return failures;

8
tools/tsc-watch/index.ts
View File

@ -95,14 +95,6 @@ if (platform == 'node') {
]
},
BaseConfig));
} else if (platform == 'tools') {
const specFiles = ['dist/all/@angular/tsc-wrapped/**/*{_,.}spec.js'];
tscWatch = new TscWatch(Object.assign(
{
tsconfig: ['tools/tsconfig.json', 'packages/tsc-wrapped/tsconfig.json'],
onChangeCmds: [createNodeTestCommand(specFiles, debugMode)]
},
BaseConfig));
} else {
throw new Error(`unknown platform: ${platform}`);
}

1
tools/validate-commit-message/commit-message.json
View File

@ -29,7 +29,6 @@
"platform-webworker-dynamic",
"router",
"upgrade",
"tsc-wrapped",
"packaging",
"changelog"

10
tools/validate-commit-message/validate-commit-message.spec.js
View File

@ -43,19 +43,19 @@ describe('validate-commit-message.js', function() {
expect(validateMessage('refactor(docs): something')).toBe(INVALID);
['INVALID COMMIT MSG: "fix(Compiler): something"\n' +
' => ERROR: "Compiler" is not an allowed scope.\n' +
' => SCOPES: aio, animations, benchpress, common, compiler, compiler-cli, core, forms, http, language-service, platform-browser, platform-browser-dynamic, platform-server, platform-webworker, platform-webworker-dynamic, router, upgrade, tsc-wrapped, packaging, changelog',
' => SCOPES: aio, animations, benchpress, common, compiler, compiler-cli, core, forms, http, language-service, platform-browser, platform-browser-dynamic, platform-server, platform-webworker, platform-webworker-dynamic, router, upgrade, packaging, changelog',
'INVALID COMMIT MSG: "feat(bah): something"\n' +
' => ERROR: "bah" is not an allowed scope.\n' +
' => SCOPES: aio, animations, benchpress, common, compiler, compiler-cli, core, forms, http, language-service, platform-browser, platform-browser-dynamic, platform-server, platform-webworker, platform-webworker-dynamic, router, upgrade, tsc-wrapped, packaging, changelog',
' => SCOPES: aio, animations, benchpress, common, compiler, compiler-cli, core, forms, http, language-service, platform-browser, platform-browser-dynamic, platform-server, platform-webworker, platform-webworker-dynamic, router, upgrade, packaging, changelog',
'INVALID COMMIT MSG: "style(webworker): something"\n' +
' => ERROR: "webworker" is not an allowed scope.\n' +
' => SCOPES: aio, animations, benchpress, common, compiler, compiler-cli, core, forms, http, language-service, platform-browser, platform-browser-dynamic, platform-server, platform-webworker, platform-webworker-dynamic, router, upgrade, tsc-wrapped, packaging, changelog',
' => SCOPES: aio, animations, benchpress, common, compiler, compiler-cli, core, forms, http, language-service, platform-browser, platform-browser-dynamic, platform-server, platform-webworker, platform-webworker-dynamic, router, upgrade, packaging, changelog',
'INVALID COMMIT MSG: "refactor(security): something"\n' +
' => ERROR: "security" is not an allowed scope.\n' +
' => SCOPES: aio, animations, benchpress, common, compiler, compiler-cli, core, forms, http, language-service, platform-browser, platform-browser-dynamic, platform-server, platform-webworker, platform-webworker-dynamic, router, upgrade, tsc-wrapped, packaging, changelog',
' => SCOPES: aio, animations, benchpress, common, compiler, compiler-cli, core, forms, http, language-service, platform-browser, platform-browser-dynamic, platform-server, platform-webworker, platform-webworker-dynamic, router, upgrade, packaging, changelog',
'INVALID COMMIT MSG: "refactor(docs): something"\n' +
' => ERROR: "docs" is not an allowed scope.\n' +
' => SCOPES: aio, animations, benchpress, common, compiler, compiler-cli, core, forms, http, language-service, platform-browser, platform-browser-dynamic, platform-server, platform-webworker, platform-webworker-dynamic, router, upgrade, tsc-wrapped, packaging, changelog']
' => SCOPES: aio, animations, benchpress, common, compiler, compiler-cli, core, forms, http, language-service, platform-browser, platform-browser-dynamic, platform-server, platform-webworker, platform-webworker-dynamic, router, upgrade, packaging, changelog']
.forEach((expectedErrorMessage, index) => {
expect(expectedErrorMessage).toEqual(errors[index]);
});