From f981dd9175c9b6d3366c1b73b838395f2eb43d45 Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Thu, 9 Jan 2020 20:59:47 +0100 Subject: [PATCH] ci: fix saucelabs bazel tests terminating after 5min (#34707) Currently Bazel always terminates the Saucelabs Bazel tests after 5mins. This is causing failing tests as Saucelabs tests usually run longer than 5mins. Our current Saucelabs idle timeout is 10min, so we should ensure that we don't exit early without properly shutting down Karma / disconnecting the browsers. PR Close #34707 --- BUILD.bazel | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/BUILD.bazel b/BUILD.bazel index 3aacc15542..23b7887cd0 100644 --- a/BUILD.bazel +++ b/BUILD.bazel @@ -55,6 +55,11 @@ filegroup( # flaky. This target runs in CI with Saucelabs and Ivy. karma_web_test( name = "saucelabs_unit_tests", + # Default timeout is moderate (5min). This causes the test to be terminated while + # Saucelabs browsers keep running. Ultimately resulting in failing tests and browsers + # unnecessarily being acquired. Our specified Saucelabs idle timeout is 10min, so we use + # Bazel's long timeout (15min). This ensures that Karma can shut down properly. + timeout = "long", tags = [ "local", "manual", @@ -69,6 +74,11 @@ karma_web_test( # This target runs in CI with View Engine as a Saucelabs and Bazel proof-of-concept. It's a # subset of the legacy saucelabs tests. name = "saucelabs_unit_tests_poc", + # Default timeout is moderate (5min). This causes the test to be terminated while + # Saucelabs browsers keep running. Ultimately resulting in failing tests and browsers + # unnecessarily being acquired. Our specified Saucelabs idle timeout is 10min, so we use + # Bazel's long timeout (15min). This ensures that Karma can shut down properly. + timeout = "long", tags = [ "local", "manual",