ci: pin ChromeDriver to a version compatible with docker image's Chrome (#28494)

By default, `webdriver-manager update` will download the latest
ChromeDriver version, which might not be compatible with the Chrome
version included in the [docker image used on CI], causing CI failures.
Previously, we used to pin the ChromeDriver version on CI in
[ngcontainer's Dockerfile][2]. This was accidentally broken in #26691,
while moving from ngcontainer to default CircleCI docker images.

This commit fixes the issue by pinning ChromeDriver to a known
compatible version.

[1]: bfd48d156d/.circleci/config.yml (L16)
[2]: bfd48d156d/tools/ngcontainer/Dockerfile (L63)

PR Close #28494
This commit is contained in:
George Kalpakas
2019-02-01 23:40:33 +02:00
committed by Matias Niemelä
parent 194710fc1d
commit fa130e9445
14 changed files with 23 additions and 14 deletions

View File

@ -11,6 +11,7 @@ function testBazel() {
node replace_angular_repo.js "./demo/WORKSPACE"
cd demo
yarn add @angular/bazel@file:../../../dist/packages-dist/bazel
yarn webdriver-manager update --gecko=false --standalone=false $CI_CHROMEDRIVER_VERSION_ARG
cp ../package.json.replace ./package.json
ng generate component widget --style=css
ng build
@ -24,7 +25,7 @@ function testNonBazel() {
rm -rf dist src/main.dev.ts src/main.prod.ts
ng build --progress=false
ng test --progress=false --watch=false
ng e2e --configuration=ci
ng e2e --configuration=ci --webdriver-update=false
}
testBazel