cargdev/angular
1
0
Fork 0
Code Issues 16 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(language-service): Extract common methods from VE and Ivy to new package (#39098)

Browse Source 
Rather than having the Ivy implementation add the VE code to the deps
list, create a new common package that both Ivy and VE depend on. This
will make it more straightforward in the future to remove the VE code
completely.

PR Close #39098
This commit is contained in:
Andrew Scott
2020-10-01 13:30:03 -07:00
committed by Joey Perrott
parent e10b3e22ac
commit faa81dcdd1
7 changed files with 78 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/language-service/ivy/BUILD.bazel
View File

@ -15,8 +15,7 @@ ts_library(
"//packages/compiler-cli/src/ngtsc/shims",
"//packages/compiler-cli/src/ngtsc/typecheck",
"//packages/compiler-cli/src/ngtsc/typecheck/api",
# TODO(atscott): Pull functions/variables common to VE and Ivy into a new package
"//packages/language-service",
"//packages/language-service/common",
"@npm//typescript",
],
)

2
packages/language-service/ivy/quick_info.ts
View File

@ -10,7 +10,7 @@ import {NgCompiler} from '@angular/compiler-cli/src/ngtsc/core';
import {DirectiveSymbol, DomBindingSymbol, ElementSymbol, ExpressionSymbol, InputBindingSymbol, OutputBindingSymbol, ReferenceSymbol, ShimLocation, Symbol, SymbolKind, VariableSymbol} from '@angular/compiler-cli/src/ngtsc/typecheck/api';
import * as ts from 'typescript';
import {createQuickInfo, SYMBOL_PUNC, SYMBOL_SPACE, SYMBOL_TEXT} from '../src/hover';
import {createQuickInfo, SYMBOL_PUNC, SYMBOL_SPACE, SYMBOL_TEXT} from '../common/quick_info';
import {findNodeAtPosition} from './hybrid_visitor';
import {filterAliasImports, getDirectiveMatches, getDirectiveMatchesForAttribute, getTemplateInfoAtPosition, getTextSpanOfNode} from './utils';

2
packages/language-service/ivy/utils.ts
View File

@ -12,7 +12,7 @@ import * as e from '@angular/compiler/src/expression_parser/ast'; // e for expr
import * as t from '@angular/compiler/src/render3/r3_ast'; // t for template AST
import * as ts from 'typescript';
import {ALIAS_NAME, SYMBOL_PUNC} from '../src/hover';
import {ALIAS_NAME, SYMBOL_PUNC} from '../common/quick_info';
/**
* Given a list of directives and a text to use as a selector, returns the directives which match