fix(ivy): element injector on the host of a component should see viewProviders of that component (#27928)

PR Close #27928
This commit is contained in:
Marc Laval
2019-01-04 15:38:40 +01:00
committed by Kara Erickson
parent 5d3dcfc6ad
commit fb7816fed4
3 changed files with 46 additions and 32 deletions

View File

@ -1188,7 +1188,11 @@ describe('providers', () => {
static ngInjectableDef = defineInjectable({factory: () => new SomeInj(inject(String))});
}
@Component({template: `<p></p>`, providers: [{provide: String, useValue: 'From my component'}]})
@Component({
template: `<p></p>`,
providers: [{provide: String, useValue: 'From my component'}],
viewProviders: [{provide: Number, useValue: 123}]
})
class MyComponent {
constructor() {}
@ -1204,7 +1208,9 @@ describe('providers', () => {
}
},
features: [
ProvidersFeature([{provide: String, useValue: 'From my component'}]),
ProvidersFeature(
[{provide: String, useValue: 'From my component'}],
[{provide: Number, useValue: 123}]),
],
});
}
@ -1237,12 +1243,24 @@ describe('providers', () => {
});
}
it('should work', () => {
it('should work from within the template', () => {
const fixture = new ComponentFixture(AppComponent);
expect(fixture.html).toEqual('<my-cmp><p></p></my-cmp>');
const p = fixture.hostElement.querySelector('p');
const injector = getInjector(p as any);
expect(injector.get(Number)).toEqual(123);
expect(injector.get(String)).toEqual('From my component');
expect(injector.get(Some).location).toEqual('From app component');
});
it('should work from the host of the component', () => {
const fixture = new ComponentFixture(AppComponent);
expect(fixture.html).toEqual('<my-cmp><p></p></my-cmp>');
const myCmp = fixture.hostElement.querySelector('my-cmp');
const injector = getInjector(myCmp as any);
expect(injector.get(Number)).toEqual(123);
expect(injector.get(String)).toEqual('From my component');
expect(injector.get(Some).location).toEqual('From app component');
});