cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ivy): move i18n instructions after listener ones (#29173)

Browse Source 
Prior to this commit, i18n instructions (i18n, i18nStart) were generated before listener instructions. As a result, event listeners were attached to the wrong element (text node, not the parent element). This change updates the order of instructions and puts i18n ones after listeners, to make sure listeners are attached to the right elements.

PR Close #29173
This commit is contained in:
Andrew Kushnir
2019-03-07 14:24:54 -08:00
committed by Kara Erickson
parent aa6db0d191
commit fd5cd100a3
3 changed files with 48 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
packages/compiler-cli/test/compliance/r3_view_compiler_i18n_spec.ts
View File

@ -1270,6 +1270,28 @@ describe('i18n support in the view compiler', () => {
verify(input, output);
});
it('should generate event listeners instructions before i18n ones', () => {
const input = `
<div i18n (click)="onClick()">Hello</div>
`;
const output = String.raw `
const $_c0$ = [${AttributeMarker.Bindings}, "click"];
const $MSG_EXTERNAL_3902961887793684628$$APP_SPEC_TS_1$ = goog.getMsg("Hello");
…
template: function MyComponent_Template(rf, ctx) {
if (rf & 1) {
$r3$.ɵelementStart(0, "div", $_c0$);
$r3$.ɵlistener("click", function MyComponent_Template_div_click_0_listener($event) { return ctx.onClick(); });
$r3$.ɵi18n(1, $MSG_EXTERNAL_3902961887793684628$$APP_SPEC_TS_1$);
$r3$.ɵelementEnd();
}
}
`;
verify(input, output);
});
});
describe('self-closing i18n instructions', () => {