cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ivy): do not use MSG_ prefix for i18nPostprocess invocation (FW-779) (#27468)

Browse Source 
Closure Compiler doesn't allow non-goo.getMsg const names to start with `MSG_`, so we should use different prefix for const that references a result of the `i18nPostprocess` fn invocation. With this update we also append file-based prefix to i18n constants (via $$ postfix) to ensure the names are unique across codebase of a project (otherwise it might lead to errors while compiling a project with Closure Compiler).

PR Close #27468
This commit is contained in:
Andrew Kushnir
2018-12-04 15:56:47 -08:00
committed by Miško Hevery
parent 44dfa606ed
commit fdf39985f0
4 changed files with 226 additions and 193 deletions
Download Patch File Download Diff File Expand all files Collapse all files

392
packages/compiler-cli/test/compliance/r3_view_compiler_i18n_spec.ts
View File

File diff suppressed because it is too large Load Diff

2
packages/compiler-cli/test/ngtsc/ngtsc_spec.ts
View File

@ -683,7 +683,7 @@ describe('ngtsc behavioral tests', () => {
`);
env.driveMain();
const jsContents = env.getContents('test.js');
expect(jsContents).toContain('i18n(1, MSG_EXTERNAL_8321000940098097247);');
expect(jsContents).toContain('i18n(1, MSG_EXTERNAL_8321000940098097247$$TEST_TS_0);');
});
it('should take i18nUseExternalIds config option into account', () => {