cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(ivy): re-enable passing upgrade tests (#28088)

Browse Source 
PR Close #28088
This commit is contained in:
Kara Erickson 2019-01-11 13:42:30 -08:00 committed by Andrew Kushnir
parent b73d6781da
commit fe4d3a1619
1 changed files with 243 additions and 250 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
packages/upgrade/test/static/integration/downgrade_module_spec.ts
View File

@ -159,8 +159,7 @@ withEachNg1Version(() => {
}); });
})); }));
fixmeIvy('FW-714: ng1 projected content is not being rendered') it('should support nesting components from different downgraded modules (via projection)',
.it('should support nesting components from different downgraded modules (via projection)',
async(() => { async(() => {
@Component({ @Component({
selector: 'ng2A', selector: 'ng2A',
@ -229,8 +228,7 @@ withEachNg1Version(() => {
}); });
})); }));
fixmeIvy('FW-714: ng1 projected content is not being rendered') it('should support manually setting up a root module for all downgraded modules',
.it('should support manually setting up a root module for all downgraded modules',
fakeAsync(() => { fakeAsync(() => {
@Injectable({providedIn: 'root'}) @Injectable({providedIn: 'root'})
class CounterService { class CounterService {
@ -322,8 +320,7 @@ withEachNg1Version(() => {
$rootScope.$apply('showB1 = true'); $rootScope.$apply('showB1 = true');
tick(); // Wait for module B to be bootstrapped. tick(); // Wait for module B to be bootstrapped.
expect(multiTrim(element.children[0].textContent)) expect(multiTrim(element.children[0].textContent)).toBe('ng2A(Counter:1 | Counter:1)');
.toBe('ng2A(Counter:1 | Counter:1)');
// Top-level component B should use the same `CounterService` instance. // Top-level component B should use the same `CounterService` instance.
$rootScope.$apply('showB2 = true'); $rootScope.$apply('showB2 = true');
@ -332,7 +329,7 @@ withEachNg1Version(() => {
expect(multiTrim(element.children[1].textContent)).toBe('Counter:1'); expect(multiTrim(element.children[1].textContent)).toBe('Counter:1');
})); }));
fixmeIvy('FW-714: ng1 projected content is not being rendered') fixmeIvy('FW-873: projected component injector hierarchy not wired up correctly')
.it('should correctly traverse the injector tree of downgraded components', async(() => { .it('should correctly traverse the injector tree of downgraded components', async(() => {
@Component({ @Component({
selector: 'ng2A', selector: 'ng2A',
@ -420,7 +417,7 @@ withEachNg1Version(() => {
}); });
})); }));
fixmeIvy('FW-714: ng1 projected content is not being rendered') fixmeIvy('FW-873: projected component injector hierarchy not wired up correctly')
.it('should correctly traverse the injector tree of downgraded components (from different modules)', .it('should correctly traverse the injector tree of downgraded components (from different modules)',
async(() => { async(() => {
@Component({ @Component({
@ -783,8 +780,7 @@ withEachNg1Version(() => {
}); });
})); }));
fixmeIvy('FW-714: ng1 projected content is not being rendered') it('should create and destroy nested, asynchronously instantiated components inside the Angular zone',
.it('should create and destroy nested, asynchronously instantiated components inside the Angular zone',
async(() => { async(() => {
let createdInTheZone = false; let createdInTheZone = false;
let destroyedInTheZone = false; let destroyedInTheZone = false;
@ -888,13 +884,10 @@ withEachNg1Version(() => {
}); });
})); }));
fixmeIvy('FW-714: ng1 projected content is not being rendered') it('should wire up nested, asynchronously instantiated components for change detection',
.it('should wire up nested, asynchronously instantiated components for change detection',
async(() => { async(() => {
@Component({ @Component(
selector: 'test', {selector: 'test', template: '{{ count }}<button (click)="increment()"></button>'})
template: '{{ count }}<button (click)="increment()"></button>'
})
class TestComponent { class TestComponent {
count = 0; count = 0;
increment() { ++this.count; } increment() { ++this.count; }