cargdev/angular
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

build: migrate references and scripts that set to build with ivy via compile=aot to use config=ivy (#33983)

Browse Source 
Since config=ivy now sets the define=compile flag and the define=angular_ivy_enabled
flag to cause usage of Ivy, we can update all of the documentation and scripts that
reference compile=aot to use config=ivy.

PR Close #33983
This commit is contained in:
Joey Perrott
2019-11-22 12:07:29 -08:00
committed by Matias Niemelä
parent d2784c7894
commit fec9f7dce5
10 changed files with 29 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/core/src/render3/util/global_utils.ts
View File

@ -17,7 +17,7 @@ import {getComponent, getContext, getDebugNode, getDirectives, getHostElement, g
*
* To see this in action run the following command:
*
* bazel run --define=compile=aot
* bazel run --config=ivy
* //packages/core/test/bundling/todo:devserver
*
* Then load `localhost:5432` and start using the console tools.

6
packages/core/test/render3/perf/README.md
View File

@ -1,7 +1,7 @@
### Build
```
yarn bazel build //packages/core/test/render3/perf:${BENCHMARK}.min_debug.es2015.js --define=compile=aot
yarn bazel build //packages/core/test/render3/perf:${BENCHMARK}.min_debug.es2015.js --config=ivy
```
### Run
@ -72,9 +72,9 @@ The resulting output should look something like this:
### Notes
To run the benchmark use `bazel run <benchmark_target>`, example:
- `yarn bazel run --define=compile=aot //packages/core/test/render3/perf:noop_change_detection`
- `yarn bazel run --config=ivy //packages/core/test/render3/perf:noop_change_detection`
To profile, append `_profile` to the target name and attach a debugger via chrome://inspect, example:
- `yarn bazel run --define=compile=aot //packages/core/test/render3/perf:noop_change_detection_profile`
- `yarn bazel run --config=ivy //packages/core/test/render3/perf:noop_change_detection_profile`
To interactively edit/rerun benchmarks use `ibazel` instead of `bazel`.

2
packages/core/test/render3/perf/profile_all.js
View File

@ -29,7 +29,7 @@ const profileTests =
// build tests
shell.exec(
`yarn bazel build --define=compile=aot ` +
`yarn bazel build --config=ivy ` +
profileTests.map((name) => `//packages/core/test/render3/perf:${name}_lib.min_debug.es2015.js`)
.join(' '));

4
packages/core/test/render3/perf/profile_in_browser.html
View File

@ -6,9 +6,9 @@
</script>
<body>
<ol>
<li>Build the benchmark using <tt>yarn bazel build //packages/core/test/render3/perf:${BENCHMARK}.min_debug.es2015.js --define=compile=aot</tt></li>
<li>Build the benchmark using <tt>yarn bazel build //packages/core/test/render3/perf:${BENCHMARK}.min_debug.es2015.js --config=ivy</tt></li>
<li>Open this file using the <tt>file://</tt> protocol and add <tt>?benchmark=BENCHMARK</tt> to the URL.</li>
<li>Open debug console for details</li>
</ol>
</body>
</html>
</html>