refactor(docs-infra): fix docs examples for tslint rules related to object properties (#38143)

This commit updates the docs examples to be compatible with the
`no-string-literal`, `object-literal-key-quotes` and
`object-literal-shorthand` tslint rules.

This is in preparation of updating the docs examples `tslint.json` to
match the one generated for new Angular CLI apps in a future commit.

PR Close #38143

aio/content/examples/router/e2e/src/app.e2e-spec.ts

@@ -20,12 +20,12 @@ describe('Router', () => {
 
       crisisHref: hrefEles.get(0),
       crisisList: element.all(by.css('app-root > div > app-crisis-center > app-crisis-list li')),
-      crisisDetail: crisisDetail,
+      crisisDetail,
       crisisDetailTitle: crisisDetail.element(by.xpath('*[1]')),
 
       heroesHref: hrefEles.get(1),
       heroesList: element.all(by.css('app-root > div > app-hero-list li')),
-      heroDetail: heroDetail,
+      heroDetail,
       heroDetailTitle: heroDetail.element(by.xpath('*[2]')),
 
       adminHref: hrefEles.get(2),

aio/content/examples/router/src/app/app.component.2.ts

@@ -15,7 +15,7 @@ import { slideInAnimation } from './animations';
 // #docregion function-binding
 export class AppComponent {
   getAnimationData(outlet: RouterOutlet) {
-    return outlet && outlet.activatedRouteData && outlet.activatedRouteData['animation'];
+    return outlet && outlet.activatedRouteData && outlet.activatedRouteData.animation;
   }
 }
 // #enddocregion function-binding

aio/content/examples/router/src/app/app.component.ts

@@ -12,6 +12,6 @@ import { slideInAnimation } from './animations';
 })
 export class AppComponent {
   getAnimationData(outlet: RouterOutlet) {
-    return outlet && outlet.activatedRouteData && outlet.activatedRouteData['animation'];
+    return outlet && outlet.activatedRouteData && outlet.activatedRouteData.animation;
   }
 }

aio/content/examples/router/src/app/auth/auth.guard.4.ts

@@ -39,7 +39,7 @@ export class AuthGuard implements CanActivate, CanActivateChild {
     // Set our navigation extras object
     // that contains our global query params and fragment
     let navigationExtras: NavigationExtras = {
-      queryParams: { 'session_id': sessionId },
+      queryParams: { session_id: sessionId },
       fragment: 'anchor'
     };
 

aio/content/examples/router/src/app/auth/auth.guard.ts

@@ -46,7 +46,7 @@ export class AuthGuard implements CanActivate, CanActivateChild, CanLoad {
     // Set our navigation extras object
     // that contains our global query params and fragment
     let navigationExtras: NavigationExtras = {
-      queryParams: { 'session_id': sessionId },
+      queryParams: { session_id: sessionId },
       fragment: 'anchor'
     };
 

aio/content/examples/router/src/app/selective-preloading-strategy.service.ts

@@ -10,7 +10,7 @@ export class SelectivePreloadingStrategyService implements PreloadingStrategy {
   preloadedModules: string[] = [];
 
   preload(route: Route, load: () => Observable<any>): Observable<any> {
-    if (route.data && route.data['preload']) {
+    if (route.data && route.data.preload) {
       // add the route path to the preloaded module array
       this.preloadedModules.push(route.path);