cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(dev-infra): save invalid commit message attempts to be restored on next commit attempt (#38304)

Browse Source 
When a commit message fails validation, rather than throwing out the commit message entirely
the commit message is saved into a draft file and restored on the next commit attempt.

PR Close #38304
This commit is contained in:
Joey Perrott
2020-07-30 14:01:03 -07:00
committed by Andrew Scott
parent afd4417a7b
commit ffd1691ba9
6 changed files with 110 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
dev-infra/commit-message/validate-file.ts
View File

@ -11,6 +11,7 @@ import {resolve} from 'path';
import {getRepoBaseDir} from '../utils/config';
import {info} from '../utils/console';
import {deleteCommitMessageDraft, saveCommitMessageDraft} from './commit-message-draft';
import {validateCommitMessage} from './validate';
/** Validate commit message at the provided file path. */
@ -18,8 +19,12 @@ export function validateFile(filePath: string) {
const commitMessage = readFileSync(resolve(getRepoBaseDir(), filePath), 'utf8');
if (validateCommitMessage(commitMessage)) {
info('√ Valid commit message');
deleteCommitMessageDraft(filePath);
return;
}
// On all invalid commit messages, the commit message should be saved as a draft to be
// restored on the next commit attempt.
saveCommitMessageDraft(filePath, commitMessage);
// If the validation did not return true, exit as a failure.
process.exit(1);
}