Matias Niemelä
1cc3fe21b6
fix(animations): do not leak DOM nodes/styling for host triggered animations ( #18853 )
...
Closes #18606
PR Close #18853
2017-09-01 10:24:14 -07:00
Vikram Subramanian
ee5591d583
fix(core): make sure onStable runs in the right zone ( #18706 )
...
Make sure the callbacks to the NgZone callbacks run in the right zone
with or without the rxjs Zone patch -
1ed83d08ac
.
PR Close #18706
2017-08-23 13:18:47 -05:00
Olivier Combe
14d34c9bdf
style(animations): format integration spec ( #18805 )
...
PR Close #18805
2017-08-21 17:09:53 -05:00
Matias Niemelä
e1f45a33b7
fix(animations): restore auto-style support for removed DOM nodes ( #18787 )
...
PR Close #18787
2017-08-18 23:32:41 -05:00
Matias Niemelä
c3dcbf9cb3
fix(animations): make sure @.disabled respects disabled parent/sub animation sequences ( #18715 )
...
Prior to this fix if @parent and @child animations ran at the same
time within a disabled region then there was a chance that a @child
sub animation would never complete. This would cause *directives to
never close a removal when a @child trigger was placed on them. This
patch fixes this issue.
PR Close #18715
2017-08-18 23:32:28 -05:00
Matias Niemelä
5d68c830d2
fix(animations): ensure animations are disabled on the element containing the @.disabled flag ( #18714 )
...
Prior to fix this fix, @.disabled would only work to disable child
animations. Now it will also disable animations for the element that has
the @.disabled flag (which makes more sense).
PR Close #18714
2017-08-18 23:32:21 -05:00
Matias Niemelä
ac58914b97
feat(animations): allow @.disabled property to work without an expression ( #18713 )
...
PR Close #18713
2017-08-18 23:32:13 -05:00
Marc Laval
fec3b1a0e9
fix(core): correct order in ContentChildren query result ( #18326 )
...
Fixes #16568
PR Close #18326
2017-08-18 23:15:17 -05:00
Daniel Kucal
259fc91305
docs(core): correct code examples for ChangeDetectorRef
2017-08-15 15:12:35 -07:00
Marc Laval
972538be7a
fix(core): forbid destroyed views to be inserted or moved in VC
...
Fixes #18615
2017-08-14 12:09:22 -07:00
Marc Laval
71f5e78bcb
test(animations): disable buggy test in Chrome 39 ( #18483 )
...
Fixes #15793
2017-08-09 14:16:03 -07:00
Matias Niemelä
e0660b1b72
fix(animations): support persisting dynamic styles within animation states ( #18468 )
...
Closes #18423
Closes #17505
2017-08-07 11:40:34 -07:00
Matias Niemelä
5a165ebcef
fix(animations): revert container/queried animations accordingly during cancel ( #18516 )
2017-08-07 11:39:04 -07:00
Victor Berchet
baf4ce0dd0
build: enable TSLint on the packages folder ( #18459 )
...
porting PRs #18392 and #18441 to 4.x
2017-08-02 15:23:33 -07:00
Miško Hevery
45a10419bc
Revert "build: Bazel builds ngfactories for packages/core ( #18289 )"
...
This reverts commit bcea1965301cf689b18448cdd9bf78c57bab7920.
2017-07-27 10:51:41 -07:00
Alex Eagle
bcea196530
build: Bazel builds ngfactories for packages/core ( #18289 )
...
PR Close #18289
2017-07-26 16:31:26 -07:00
Alex Eagle
434ff5fecb
build: update bazel rules to latest ( #18289 )
2017-07-26 12:08:24 -05:00
Vikram Subramanian
a1bb9c2d42
fix(core): invoke error handler outside of the Angular Zone ( #18269 )
...
In Node.JS console.log/error/warn functions actually resuls in a socket
write which in turn is considered by Zone.js as an async task.
This means that if there is any exception during change detection in a platform-server
application the error handler will make the Angular Zone unstable which
in turn will cause change detection to run on next tick and cause an
infinite loop.
It is also better to run the error handler outside of the Angular Zone
in general on all platforms so that an error in the error handler itself doesn't cause an
infinite loop.
Fixes #17073 , #7774 .
PR Close #18269
2017-07-26 12:04:47 -05:00
Vikram Subramanian
97135e8fd5
fix(platform-server): don't clobber parse5 properties when setting ( #18237 )
...
element properties.
Fixes #17050 .
We now store all element properties in a separate 'properties' bag.
PR Close #18237
2017-07-26 12:04:47 -05:00
Matias Niemelä
a5c4bb5b96
fix(animations): make sure @.disabled works in non-animation components
...
Note 4.3 only!
Prior to this fix when [@.disabled] was used in a component that
contained zero animation code it wouldn't register properly because the
renderer associated with that component was not an animation renderer.
This patch ensures that it gets registered even when there are no
animations set.
2017-07-19 09:50:03 -07:00
Matias Niemelä
4c1f32b0db
fix(animations): do not crash animations if a nested component fires CD during CD
...
Closes #18193
2017-07-19 09:49:57 -07:00
Matias Niemelä
383d8969ab
fix(animations): always camelcase style property names that contain auto styles
...
Closes #17938
2017-07-19 09:49:47 -07:00
Matias Niemelä
333ffd8d32
fix(animations): capture cancelled animation styles within grouped animations
...
Closes #17170
2017-07-19 09:49:42 -07:00
Alex Rickabaugh
f7686d4124
Revert "fix(animations): make sure @.disabled works in non-animation components"
...
This reverts commit 01a2688848759dfc60c478f7641ca05338241c59.
2017-07-14 11:00:29 -07:00
Matias Niemelä
01a2688848
fix(animations): make sure @.disabled works in non-animation components
...
Note 4.3 only!
Prior to this fix when [@.disabled] was used in a component that
contained zero animation code it wouldn't register properly because the
renderer associated with that component was not an animation renderer.
This patch ensures that it gets registered even when there are no
animations set.
2017-07-14 10:34:58 -07:00
meDavid
a9757ec674
docs: Fix code example in the ChangeDetectorRef docs ( #18051 )
...
Minor example fix: mark the 'ref' constructor parameter as a private property
2017-07-11 11:45:32 -07:00
Victor Berchet
c723d42d0a
refactor: fix typos ( #18000 )
2017-07-07 16:55:17 -07:00
Victor Berchet
9c1f6fd06f
fix(compiler): emits quoted keys only iff they are quoted in the original template
...
fixes #14292
2017-07-07 16:17:33 -07:00
Matias Niemelä
8e28382e4a
feat(animations): support disabling animations for sub elements
...
Closes #16483
2017-07-07 14:58:40 -07:00
Matias Niemelä
3203639d7d
fix(animations): ensure :animating
queries collect previous animation elements properly
2017-07-07 14:58:40 -07:00
Matias Niemelä
f85b543cc1
fix(animations): properly detect state transition changes for object literals
2017-07-07 14:58:40 -07:00
Victor Berchet
c69fff15c9
fix(core): fix re-insertions in the iterable differ ( #17891 )
...
fixes #17852
2017-07-06 12:11:47 -07:00
Matias Niemelä
105e920b69
fix(animations): properly handle cancelled animation style application
2017-07-06 10:18:12 -07:00
Matias Niemelä
858dea98e5
fix(animations): properly cleanup query artificats when animation construction fails
2017-07-06 10:18:12 -07:00
Jason Aden
b479ed9407
perf(core): refactor NgZone, decrease size by 1.2Kb ( #17773 )
...
- Remove getters
- Hide private methods for better property renaming
```
497893 May 31 11:26 core.umd.js
718073 May 31 11:26 core.umd.js.map
217108 May 31 11:26 core.umd.min.js
575092 May 31 11:26 core.umd.min.js.map
```
```
495594 May 31 11:28 core.umd.js
716943 May 31 11:28 core.umd.js.map
215826 May 31 11:28 core.umd.min.js
574401 May 31 11:28 core.umd.min.js.map
```
diff: 1,282
2017-07-01 10:29:56 -07:00
Matias Niemelä
af14b1e384
test(animations): add proper tests to check multiple combinations of :enter/:leave animation queries
2017-06-28 18:18:10 -07:00
Matias Niemelä
40f77cb563
fix(animations): properly collect :enter nodes that exist within multi-level DOM trees
...
Closes #17632
2017-06-28 18:18:10 -07:00
Matias Niemelä
d699c354db
fix(animations): do not remove container nodes when children are queried by a parent animation
...
Closes #17746
2017-06-27 11:00:17 -07:00
Matias Niemelä
34f3832af9
fix(animations): do not delay style() values before a stagger() runs
...
Closes #17412
2017-06-27 11:00:06 -07:00
Alex Eagle
e80851d98b
fix(core): add needed closure compiler warning suppression
2017-06-23 14:44:00 -07:00
Alex Rickabaugh
c59c390cdc
fix: argument destructuring sometimes breaks strictNullChecks
...
Destructuring of the form:
function foo({a, b}: {a?, b?} = {})
breaks strictNullChecks, due to the TypeScript bug https://github.com/microsoft/typescript/issues/10078 .
This change eliminates usage of destructuring in function argument lists in cases where it would leak
into the public API .d.ts.
2017-06-20 12:56:08 -07:00
Pawel Kozlowski
009651e14f
refactor(core): remove toString() method from DefaultKeyValueDiffer
...
toString() from DefaultKeyValueDiffer is only used in tests and should not
be part of the production code. toString() methods from differs add
~ 0.3KB (min+gzip) to the production bundle size.
2017-06-20 12:55:20 -07:00
Matias Niemelä
6ca46929fa
fix(animations): properly collect :enter nodes in a partially updated collection
...
This PR fixes an issue where `query(':enter')` will only collect elements up until it an element that is found that isn't apart of the `:enter` query.
Closes #17440
2017-06-12 15:26:46 -07:00
Matias Niemelä
185075d870
fix(animations): compute removal node height correctly
2017-06-12 12:18:26 -07:00
Matias Niemelä
451257a2fd
fix(animations): do not treat a 0
animation state as void
2017-06-12 12:18:15 -07:00
Alex Eagle
5faf520067
build: Introduce Bazel build rules
...
So far this just compiles the core and common packages.
2017-06-05 11:18:20 -07:00
Matias Niemelä
068133ec85
fix(animations): do not retain deleted nodes during an non-removal animation ( #17153 )
...
Closes #17086
2017-06-01 14:02:41 -07:00
Matias Niemelä
665e7071fa
fix(animations): always change to desired animation state even if no transition fires ( #17025 )
...
Fixes #16947
2017-05-31 15:36:41 -07:00
Matias Niemelä
d108479d84
fix(animations): use a lightweight renderer for non-animation components ( #17003 )
...
This reverts commit c0981b8e13556e0481332d11f9739890593cd447.
2017-05-26 14:39:42 -06:00
Chuck Jazdzewski
c0981b8e13
Revert "fix(animations): use a lightweight renderer for non-animation components ( #17003 )"
...
This reverts commit 3ab86bd66162ca94de46e90d2754fcdf96f78c51.
2017-05-26 08:55:23 -07:00