cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
9,557 Commits 56 Branches 477 Tags
Commit Graph

9557 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jamie Krug
2a38d93171 docs(aio): fix doc typo referring to httpOptions (#22456) 
The variable name mention should match the actual tutorial code.

PR Close #22456
 2018-02-26 13:32:44 -08:00
George Kalpakas
a9a0e27e94 fix(upgrade): fix empty transclusion content with AngularJS@>=1.5.8 (#22167) 
The function provided by `ngUpgrade` as `parentBoundTranscludeFn` when
upgrading a component with transclusion, will break in AngularJS v1.5.8+
if no transclusion content is provided. The reason is that AngularJS
will try to destroy the transclusion scope (which would not be needed
any more). But since the transcluded content comes from Angular, not
AngularJS, there is no transclusion scope to destroy.
This commit fixes it by providing a dummy scope object with a no-op
`$destroy()` method.

Fixes #22175

PR Close #22167
 2018-02-25 10:06:14 -08:00
George Kalpakas
66383901a6 fix(upgrade): correctly handle = bindings in @angular/upgrade (#22167) 
Previously, having a `=` binding on an upgraded components would result
in setting the corresponding property to an EventEmitter function. This
should only happen for `&` bindings.
This commit rstrores the correct behavior.

Note:
The issue was only present in the dynamic version of `ngUpgrade`. The
static version worked as expected.
The error did not show up in tests, because in AngularJS v1.5.x a
function would be serialized to an empty string in interpolations, thus
making them indistinguishable from uninitialized properties (in the
view). The serialization behavior changed in AngularJS v1.6.x, making
the errors visible.

PR Close #22167
 2018-02-25 10:06:14 -08:00
George Kalpakas
1eb54132e4 test(upgrade): run tests against multiple AngularJS versions (#22167) 
Fixes #19332

PR Close #22167
 2018-02-25 10:06:14 -08:00
George Kalpakas
6c9c173e1e refactor(upgrade): use correct paths for imports (#22167) 
`packages/upgrade/static/src` is anymlink to `packages/upgrade/src`.
Still, using the correct paths (e.g. using
`@angular/upgrade/static/src/...` for `@angula/upgrade/static` specs
ensures that the module loader (e.g. SystemJS) can map the imports to
the same instances.

PR Close #22167
 2018-02-25 10:06:14 -08:00
George Kalpakas
1e08a945e1 test(platform-browser): remove stray debugger statement (#22167) 
PR Close #22167
 2018-02-25 10:06:14 -08:00
Victor Berchet
4a08745d3e build: add support for the "merge-assistance" label in merge-pr (#22414) 
fixes #22256

PR Close #22414
 2018-02-23 12:58:30 -08:00
hariharanjv
cf91906d8f docs(aio): Essential JS 2 url updated (#19739) 
PR Close #19739
 2018-02-23 11:18:12 -08:00
ROOT\hariharanjv
0723c04a01 docs(aio): Essential JS 2 UI Components. (#19739) 
PR Close #19739
 2018-02-23 11:18:12 -08:00
Alex Eagle
2b7188906b build: fix 5.2.x merge (#22408) 
PR Close #22408
 2018-02-23 10:21:33 -08:00
Alex Eagle
17c1577de9 ci: don't use bazel git_repository rule (#22406) 
It's currently broken on CircleCI because of a TLS change made by GitHub.
This is okay as a permanent change, we don't really want bazel to fetch a full git history.

Fixes #22405

PR Close #22406
 2018-02-23 09:41:11 -08:00
Kapunahele Wong
150bac310f docs: fix deployment sample path (#22048) 
PR Close #22048
 2018-02-22 13:40:57 -08:00
Jason Aden
8f0a0641e2 fix(router): don't mutate route configs (#22358) 
Fixes #22203

PR Close #22358
 2018-02-22 13:35:38 -08:00
Alex Eagle
17762390c9 build: disable bazel-out symlink (#22375) 
It causes headaches on MacOS High Sierra, see https://github.com/bazelbuild/bazel/issues/4603

PR Close #22375
 2018-02-22 13:33:12 -08:00
Kapunahele Wong
da1b4d5ea7 docs: fix ngmodules-jsmodules pre-req (#22316) 
closes #22157

PR Close #22316
 2018-02-22 11:20:48 -08:00
Kapunahele Wong
aa100f69f2 docs: edit styleguide recommendation on components as elements (#22074) 
Change recommendation on using attributes for components since there are use cases including the use of <button mat-button> in MD

Closes #19401.

PR Close #22074
 2018-02-22 11:20:21 -08:00
Martin Probst
9cca5a8c9c build: allow passing node options to ngc. (#22245) 
PR Close #22245
 2018-02-22 10:23:54 -08:00
Victor Berchet
7c3b95b4ab
docs: add changelog for 5.2.6 5.2.6 2018-02-21 16:45:10 -08:00
Victor Berchet
e4e8a68c06
release: cut the 5.2.6 release 2018-02-21 16:45:09 -08:00
Victor Berchet
6460ac0add
Revert "feat(platform-browser): fix #19604, can config hammerOptions (#21979)" 
This reverts commit fdbfd21bcdae775bb6fbaa6e407998f796fd2613.
 2018-02-21 16:45:09 -08:00
Trotyl
ee91de9d5a feat(core): support metadata reflection for native class types (#22356) 
closes #21731

PR Close #22356
 2018-02-21 16:09:27 -08:00
Trotyl
5ec38f2f47 fix(core): properly handle function without prototype in reflector (#22284) 
closes #19978

PR Close #22284
 2018-02-21 14:52:05 -08:00
Marco Alvarado
612cfeca14 docs(aio): updates directive event hooks real capabilities (#16654) 
Minor documentation update to include event hooks that were assumed to only work on components.

Closes angular/angular#10221

PR Close #16654
 2018-02-21 14:51:05 -08:00
zhilich
dfdade25ea docs(aio): Wrong code example. Form status field was added later in the guide. (#21275) 
PR Close #21275
 2018-02-21 11:06:48 -08:00
Ricardo M
c2f78e1ca3 docs(http): fix a typo in code comment (#22327) 
PR Close #22327
 2018-02-21 11:06:06 -08:00
Victor Berchet
484802cd2a build: make git revert messages valid (#22339) 
`git revert` default message is "Revert <original message>" (no semi-colon)

PR Close #22339
 2018-02-21 11:05:35 -08:00
Kapunahele Wong
ee535777bb docs: add ngStyle to cheat sheet (#22070) 
PR Close #22070
 2018-02-20 16:08:16 -08:00
Ro Savage
94756eb4bd docs(aio): fix incorrect quote mark usage (#22335) 
PR Close #22335
 2018-02-20 15:42:55 -08:00
Oussama Ben Brahim
23b0707707 docs(aio): fix the css of the heroes component's buttons (#22333) 
Fixes #22222

PR Close #22333
 2018-02-20 15:41:57 -08:00
Pascal Zwick
a2cb0109f1 docs(aio): Fix name of component (#22332) 
PR Close #22332
 2018-02-20 15:41:35 -08:00
Stephen Fluin
d20a08bc48 docs(aio): update installed mobile tool list (#22331) 
PR Close #22331
 2018-02-20 15:41:15 -08:00
Alex Eagle
5bdb3acace build: update tsickle dep from compiler-cli (#22295) 
PR Close #22295
 2018-02-20 15:40:45 -08:00
Alex Eagle
c5418c7abe fix(compiler-cli): add missing entry point to package, update tsickle (#22295) 
PR Close #22295
 2018-02-20 15:40:45 -08:00
Jeff Cross
09b4612bdd docs(aio): add Nx and Angular Enterprise Playbook to resources (#22321) 
PR Close #22321
 2018-02-20 10:09:34 -08:00
Frederik Prijck
a346d28df6 test(language-service): fix minor typos (#21372) 
PR Close #21372
 2018-02-20 10:08:55 -08:00
Victor Berchet
bf07837d5d test(common): fix ngIf tests 
The failing test was ported for the master branch which ignores whitespaces
 2018-02-18 20:12:47 -08:00
Victor Berchet
cdfedc1e49 fix(common): fix merge error in ng_if.ts 2018-02-18 19:51:15 -08:00
Victor Berchet
af6a0563de fix(common): then and else template might be set to null (#22298) 
PR Close #22298
 2018-02-18 19:28:36 -08:00
Johannes Hoppe
c726d1d6d3 docs(aio): add angular-buch to resources (#22163) 
adds a link to the website of our book. second version of the text. thanks!

PR Close #22163
 2018-02-18 15:12:14 -08:00
Johannes Hoppe
2030846df7 docs(aio): add angular-buch to resources (#22163) 
adds a link to the website of our book. many thanks for reviewing this

PR Close #22163
 2018-02-18 15:12:14 -08:00
Derk Snijders - i3anaan
9dae97c5d9 docs: correct grammar mistakes in CONTRIBUTING.md (#22285) 
Various grammar mistakes were present in the contribution guidelines
This commit corrects some of them

PR Close #22285
 2018-02-18 13:27:24 -08:00
George Kalpakas
228eb9feef fix(aio): improve announcement-bar layout with wide logos (#22272) 
PR Close #22272
 2018-02-18 13:16:30 -08:00
Joe Eames
debf01d7a6 docs(aio): added ngconf announcement (#22272) 
PR Close #22272
 2018-02-18 13:16:30 -08:00
Victor Berchet
51abe69b60 fix: merge-pr script (#22290) 
PR Close #22290
 2018-02-18 13:13:29 -08:00
Victor Berchet
396bc0d9e9 build: use authenticated mode for the merge script (#22269) 
`TOKEN` is the name with use for other GH scripts

PR Close #22269
 2018-02-18 13:01:51 -08:00
Olivier Combe
861250b4e2 docs: fix changelog errors (#22228) 
PR Close #22228
 2018-02-16 18:03:04 -08:00
Fabian Wiles
81c1e0a3c3 docs: replace plnkr with StackBlitz (#20365) 
PR Close #20365
 2018-02-16 15:12:10 -08:00
Trotyl Yu
ce5e8fad9e fix(common): correct mapping of Observable methods (#20518) 
fixes #20516
PR Close #20518
 2018-02-16 15:10:31 -08:00
Alex Eagle
185a6ab562 build: add esm5 build (#22258) 
This is a partial cherry-pick of 370ab66c4f020da7e1a6b25b96109f1b3cbf9cba
which included this along with a new feature for ivy.

PR Close #22258
 2018-02-16 14:49:24 -08:00
George Kalpakas
6b457843b9 test(aio): increase docs-test timeouts to prevent flakes on Travis (#22261) 
PR Close #22261
 2018-02-16 14:46:23 -08:00