cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
15,604 Commits 56 Branches 477 Tags
Commit Graph

79 Commits

Author SHA1 Message Date
Danny Skoog
6ab5f3648a refactor: utilize type narrowing (#33075) 
PR Close #33075
 2019-10-10 15:18:44 -07:00
Carlos Ortiz García
9166baf709 refactor(core): Migrate TestBed.get to TestBed.inject (#32382) 
This is cleanup/followup for PR #32200

PR Close #32382
 2019-09-09 19:10:54 -04:00
Matias Niemelä
5a582a8afd fix(ivy): ensure element removal triggers host removal animations (#28162) 
Prior to this fix Ivy would not execute any animation triggers
that exist as host bindings on an element if it is removed by
the parent template.

PR Close #28162
 2019-01-17 09:58:50 -08:00
JoostK
df123e0410 fix(animations): mark actual descendant node as disabled (#26180) 
PR Close #26180
 2018-12-14 15:19:56 -08:00
Martin Probst
d76531d16e fix(animations): @internal must use JSDoc tags. (#24928) 
This change fixes up several comments that accidentally used the JSDoc
tag @internal in regular block comments (`/*` instead of `/**`).

This prevents a problem with Closure Compiler that balks at `@` tags
occuring in regular block comments, because it assumes they were
intended to be tags for the compiler.

When occuring in `/**` JSDoc, tsickle escapes the tags, so they do not
cause problems.

PR Close #24928
 2018-07-18 18:18:04 -04:00
Rado Kirov
c95437f15d build(bazel): Turning on strictPropertyInitialization for Angular. (#24572) 
All errors for existing fields have been detected and suppressed with a
`!` assertion.

Issue/24571 is tracking proper clean up of those instances.

One-line change required in ivy/compilation.ts, because it appears that
the new syntax causes tsickle emitted node to no longer track their
original sourceFiles.

PR Close #24572
 2018-06-25 07:57:13 -07:00
Matias Niemelä
e8354edcd2 test(animations): properly reference body node for SSR environments (#23300) 
PR Close #23300
 2018-06-20 11:00:41 -07:00
Matias Niemelä
dc4a3d00d0 fix(animations): always render end-state styles for orphaned DOM nodes (#24236) 
This patch ensures that any destination animation styling (state values)
are always applied even if the DOM node is not apart of the DOM.

PR Close #24236
 2018-06-08 16:35:26 -07:00
Matias Niemelä
8db928df9d fix(animations): retain trigger-state for nodes that are moved around (#24238) 
This patch ensures that if a list of nodes (that contain
animation triggers) are moved around then they will retain their
trigger-value state when animated again at a later point.

PR Close #24238
 2018-06-05 18:29:47 -07:00
Matias Niemelä
d2a86872a9 fix(animations): do not throw errors when a destroyed component is animated (#23836) 
PR Close #23836
 2018-05-11 16:08:14 -04:00
Matias Niemelä
65211f46cf fix(animations): retain state styling for nodes that are moved around (#23534) 
PR Close #23534
 2018-05-02 16:58:46 -07:00
Veres Lajos
de90314304 style: typos fixed - https://github.com/vlajos/misspell-fixer (#22975) 
PR Close #22975
 2018-03-27 14:51:53 -04:00
Matias Niemelä
f88fba020b fix(animations): avoid animation insertions during router back/refresh (#21977) 
Closes #19712

PR Close #21977
 2018-03-22 17:59:41 -04:00
Matias Niemelä
58b94e6f5e feat(animations): expose element and params within transition matchers (#22693) 
PR Close #22693
 2018-03-13 09:42:24 -07:00
Matias Niemelä
e1bf067090 fix(animations): report correct totalTime value even during noOp animations (#22225) 
This patch ensures that if the NoopAnimationsModule is used then it will
correctly report the associated `totalTime` property within the emitted
AnimationEvent instance when an animation event trigger is fired.

BREAKING CHANGE: When animation is trigged within a disabled zone, the
associated event (which an instance of AnimationEvent) will no longer
report the totalTime as 0 (it will emit the actual time of the
animation). To detect if an animation event is reporting a disabled
animation then the `event.disabled` property can be used instead.

PR Close #22225
 2018-02-16 18:03:31 -08:00
Matias Niemelä
13e663c232 fix(animations): ensure multi-level route leave animations are queryable (#20787) 
Closes #19807

PR Close #20787
 2017-12-08 13:44:01 -08:00
Yuan Gao
e544742156 refactor(core): Removed readonly getters and changed to readonly (#19842) 
variables

PR Close #19842
 2017-12-08 10:24:19 -08:00
Matias Niemelä
c2b3792a3b fix(animations): ensure multi-level leave animations work (#19455) 
PR Close #19455
 2017-11-28 18:24:41 -06:00
Matias Niemelä
b2a586cee1 fix(animations): ensure multi-level enter animations work (#19455) 
PR Close #19455
 2017-11-28 18:24:40 -06:00
Miško Hevery
add5953aa1 Revert "fix(animations): ensure multi-level enter animations work (#19455)" 
This reverts commit dd6237ecd97123e8122dd30d6ae1d546fed599b8.
 2017-11-28 15:08:44 -06:00
Miško Hevery
6b4c24020d Revert "fix(animations): ensure multi-level leave animations work (#19455)" 
This reverts commit 1366762d12e0faa857deb793255099bfe0e0f717.
 2017-11-28 15:08:31 -06:00
Matias Niemelä
1366762d12 fix(animations): ensure multi-level leave animations work (#19455) 
PR Close #19455
 2017-11-27 16:59:47 -06:00
Matias Niemelä
dd6237ecd9 fix(animations): ensure multi-level enter animations work (#19455) 
PR Close #19455
 2017-11-27 16:59:46 -06:00
Matias Niemelä
0e012c9669 fix(animations): always fire inner trigger callbacks even if blocked by parent animations (#19753) 
Closes #19100

PR Close #19753
 2017-11-22 10:38:02 -06:00
Miško Hevery
f8658cdc38 Revert "fix(animations): always fire inner trigger callbacks even if blocked by parent animations (#19753)" 
This reverts commit d47b2a6f706c42c049bf0faf1112c97ecf681c0a.
 2017-11-15 17:04:22 -06:00
Matias Niemelä
d47b2a6f70 fix(animations): always fire inner trigger callbacks even if blocked by parent animations (#19753) 
Closes #19100

PR Close #19753
 2017-11-14 15:59:47 -08:00
Matias Niemelä
20aafff092 fix(animations): ensure final state() styles are applied within @.disabled animations (#20267) 
Closes #20266

PR Close #20267
 2017-11-14 11:01:11 -08:00
Bowen Ni
743651f5e8 refactor(animations): uses a loop instead Array.map() which creates and (#19910) 
returns a new array that is discarded.

This pattern will become a compilation error in google3.

PR Close #19910
 2017-11-10 13:47:02 -08:00
Tobias Bosch
8d735da5d8 Revert "fix(animations): always fire inner trigger callbacks even if blocked by parent animations (#19753)" 
This reverts commit 5a9ed2de272912ac74ed56bfec4bdf4551f7b38e.
As it broke an internal test.
 2017-10-18 09:56:59 -07:00
Matias Niemelä
5a9ed2de27 fix(animations): always fire inner trigger callbacks even if blocked by parent animations (#19753) 
Closes #19100

PR Close #19753
 2017-10-17 20:57:57 -07:00
Matias Niemelä
d035175cdb fix(animations): ensure inner :leave animations do not remove node when skipped (#19532) (#19693) 
PR Close #19693
 2017-10-16 11:13:58 -07:00
Matias Niemelä
f42d317d2f fix(animations): ensure animateChild() works with all inner leave animations (#19006) (#19532) (#19693) 
PR Close #19693
 2017-10-16 11:13:58 -07:00
Chuck Jazdzewski
46992b4bda Revert "fix(animations): ensure animateChild() works with all inner leave animations (#19006) (#19532)" 
This reverts commit 9130505b57c10dc6f4cd9b12ca47e06c4f429b74.
 2017-10-11 10:51:52 -07:00
Chuck Jazdzewski
d0af45c31a Revert "fix(animations): ensure inner :leave animations do not remove node when skipped (#19532)" 
This reverts commit ac50bd678ee37c4b222baccc8412cc153a1d5a20.
 2017-10-11 10:37:12 -07:00
Matias Niemelä
ac50bd678e fix(animations): ensure inner :leave animations do not remove node when skipped (#19532) 
PR Close #19532
 2017-10-10 12:41:47 -07:00
Matias Niemelä
9130505b57 fix(animations): ensure animateChild() works with all inner leave animations (#19006) (#19532) 
Closes #18305

PR Close #19532
 2017-10-10 12:41:47 -07:00
Matias Niemelä
c4704c8abc fix(animations): properly support boolean-based transitions and state changes (#19279) 
Closes #9396
Closes #12337

PR Close #19279
 2017-10-09 10:00:32 -07:00
Chuck Jazdzewski
f4480d46b4 Revert "fix(animations): ensure animateChild() works with all inner leave animations (#19532)" 
This reverts commit 1c77cdadaf8d1ac24751a218484a8a08c13bad18.
 2017-10-06 18:15:22 -07:00
Chuck Jazdzewski
6aa7cc1d96 Revert "fix(animations): properly support boolean-based transitions and state changes (#19279)" 
This reverts commit a8920eb774346d809e03d992c454de18664b1be0.
 2017-10-06 18:15:08 -07:00
Matias Niemelä
a8920eb774 fix(animations): properly support boolean-based transitions and state changes (#19279) 
Closes #9396
Closes #12337

PR Close #19279
 2017-10-06 15:35:37 -07:00
Matias Niemelä
1c77cdadaf fix(animations): ensure animateChild() works with all inner leave animations (#19532) 
Closes #18305

PR Close #19532
 2017-10-06 15:35:13 -07:00
Victor Berchet
6a9ce67714 Revert "refactor(core): Removed readonly getters and changed to readonly (#19225)" 
This reverts commit 2b84b86fc08a4ecb3078bd8b3a1bfc7b07946b20.
 2017-09-28 13:36:44 -07:00
tinayuangao
2b84b86fc0 refactor(core): Removed readonly getters and changed to readonly (#19225) 
variables
 2017-09-28 09:36:29 -07:00
Yuan Gao
549f2254b4 refactor(core): remove getters for packages/animations, language-service, platform-browser, router (#19151) 
PR Close #19151
 2017-09-20 12:38:37 -07:00
Miško Hevery
15945c8791 Revert "fix(animations): ensure animateChild() works with all inner leave animations (#19006)" 
This reverts commit a95e03ae85839a89a6222e60d39ae9fe1094b35e.
 2017-09-05 23:08:26 -05:00
Matias Niemelä
a95e03ae85 fix(animations): ensure animateChild() works with all inner leave animations (#19006) 
Closes #18305

PR Close #19006
 2017-09-05 15:33:50 -05:00
Matias Niemelä
fcadeb2079 fix(animations): do not leak DOM nodes/styling for host triggered animations (#18853) 
Closes #18606

PR Close #18853
 2017-08-31 18:38:27 -07:00
Matias Niemelä
409688fe17 feat(animations): report errors when invalid CSS properties are detected (#18718) 
Closes #18701

PR Close #18718
 2017-08-21 20:38:22 -05:00
Matias Niemelä
70628112e8 fix(animations): restore auto-style support for removed DOM nodes (#18787) 
PR Close #18787
 2017-08-18 23:31:10 -05:00
Matias Niemelä
29aa8b33df fix(animations): make sure animation cancellations respect AUTO style values (#18787) 
Closes #17450

PR Close #18787
 2017-08-18 23:31:10 -05:00