cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
18,481 Commits 56 Branches 477 Tags
Commit Graph

5 Commits

Author SHA1 Message Date
Alessandro
4107abba2d refactor(common): use getElementById in ViewportScroller.scrollToAnchor (#38372) 
This commit uses getElementById and getElementsByName when an anchor scroll happens,
to avoid escaping the anchor and wrapping the code in a try/catch block.

Related to #28960

PR Close #38372
 2020-08-07 11:17:53 -07:00
marcvincenti
58f4b3ad80 fix(common): ensure scrollRestoration is writable (#30630) (#38357) 
Some specialised browsers that do not support scroll restoration
(e.g. some web crawlers) do not allow `scrollRestoration` to be
writable.

We already sniff the browser to see if it has the `window.scrollTo`
method, so now we also check whether `window.history.scrollRestoration`
is writable too.

Fixes #30629

PR Close #30630

PR Close #38357
 2020-08-05 17:49:56 -07:00
Joey Perrott
6f829180f7 build: update license headers to reference Google LLC (#37205) 
Update the license headers throughout the repository to reference Google LLC
rather than Google Inc, for the required license headers.

PR Close #37205
 2020-05-26 14:27:01 -04:00
Joey Perrott
698b0288be build: reformat repo to new clang@1.4.0 (#36613) 
PR Close #36613
 2020-04-14 12:08:36 -07:00
Jason Aden
e8768acacc fix(common): escape query selector used when anchor scrolling (#29577) 
When an anchor scroll happens, we run document.querySelector. This value can be taken directly from the user. Therefore it's possible to throw an error on scrolling, which can cause the application to fail.

This PR escapes the selector before using it.

Related to #28193
[Internal discussion](https://groups.google.com/a/google.com/forum/#!topic/angular-users/d82GHfmRKLc)

PR Close #29577
 2019-03-29 10:39:38 -07:00