Alex Rickabaugh
5581e97d2a
fix(core): call ngOnDestroy on all services that have it ( #23755 )
...
Previously, ngOnDestroy was only called on services which were statically
determined to have ngOnDestroy methods. In some cases, such as with services
instantiated via factory functions, it's not statically known that the service
has an ngOnDestroy method.
This commit changes the runtime to look for ngOnDestroy when instantiating
all DI tokens, and to call the method if it's present.
Fixes #22466
Fixes #22240
Fixes #14818
PR Close #23755
2018-05-08 13:55:29 -07:00
Igor Minar
19262d9f90
Revert "style(animations): fix short param names ( #23668 )"
...
This reverts commit e3518967ad705b133ee21eedcf9546b5cb2e817e.
This PR accidentaly introduces a breaking change:
https://github.com/angular/angular/pull/23668#discussion_r186265055
2018-05-05 08:40:35 -07:00
Igor Minar
1eb1c6315d
Revert "docs(animations): fix content errors ( #23668 )"
...
This reverts commit 005dc8f68b9d09f2a4db46bdbfae3e05d3604818.
The PR accidently introduced a breaking change
https://github.com/angular/angular/pull/23668#discussion_r186265055
2018-05-05 08:38:13 -07:00
Pete Bacon Darwin
3807599a4d
style(animations): fix short param names ( #23668 )
...
PR Close #23668
2018-05-05 08:17:02 -07:00
Pete Bacon Darwin
2ed41d9e38
docs(animations): fix content errors ( #23668 )
...
PR Close #23668
2018-05-05 08:17:02 -07:00
Alex Eagle
5eb9c01bb6
ci: hide encryption key from circleci logs ( #23585 )
...
PR Close #23585
2018-05-04 16:33:59 -07:00
Alex Eagle
09d9662386
build: serve ivy todo app with real http-server ( #23446 )
...
PR Close #23446
2018-05-04 16:33:53 -07:00
Alex Eagle
844cbd9774
ci: publish build snapshots from Bazel/CircleCI ( #23512 )
...
This uses a new script and CircleCI job called "build-packages-dist"
which shims the new Bazel build to produce outputs matching the legacy
build. We'll use this to get AIO testing onto CircleCI as well.
We move the integration tests to a new circleCI job that depends on this
one, as well as the build publishing job.
Note that every PR will have a trivial green publishing status, because
we always create this job even for PRs. We'd rather not - see
https://discuss.circleci.com/t/workflows-pull-request-filter/14396/4
PR Close #23512
2018-05-04 16:33:39 -07:00
Igor Minar
373a47dda9
test: fix firebase deployment script test
...
When I fixed the project id in 2c4850dc582287b7c34d4d26066fe4993638cbf0,
I didn't realize we had a test that verified the wrong behavior.
2018-05-04 15:40:50 -07:00
Alex Eagle
83f12f3047
build: update to latest nodejs bazel rules ( #23683 )
...
PR Close #23683
2018-05-04 15:29:03 -07:00
Alex Eagle
bbc416cdcd
build: update bazel to 0.13 ( #23623 )
...
PR Close #23623
2018-05-04 15:23:56 -07:00
Igor Minar
07f2098655
feat(aio): add v6 release notification ( #23690 )
...
PR Close #23690
2018-05-04 15:23:36 -07:00
George Kalpakas
9b53a6e779
fix(aio): remove main background color when printing ( #23538 )
...
PR Close #23538
2018-05-04 15:21:14 -07:00
George Kalpakas
65f8505fb6
fix(aio): fix code-example
print styles when printing backgrounds ( #23538 )
...
Fixes #23431
PR Close #23538
2018-05-04 15:21:14 -07:00
George Kalpakas
5a5ea45c40
refactor(aio): use the same selectors for screen and print styles ( #23538 )
...
PR Close #23538
2018-05-04 15:21:14 -07:00
George Kalpakas
52a3657b48
refactor(aio): include print styles last to overwrite other styles ( #23538 )
...
PR Close #23538
2018-05-04 15:21:14 -07:00
Matias Niemelä
3824e3f858
fix(animations): properly clean up queried element styles in safari/edge ( #23686 )
...
Prior to this patch, if an element is queried and animated for 0 seconds
(just a style() call and nothing else) then the styles applied would not
be properly cleaned up due to their camelCased nature.
PR Close #23686
2018-05-04 15:04:20 -07:00
Matias Niemelä
05aa5e0179
fix(animations): retain state styling for nodes that are moved around ( #23686 )
...
PR Close #23686
2018-05-04 15:04:20 -07:00
Filipe Silva
4ddeb030e7
build(aio): use Angular 6.0.0 ( #23687 )
...
PR Close #23687
2018-05-03 16:05:34 -07:00
Filipe Silva
afe6380429
build(aio): update to Angular CLI 6.0.0 ( #23687 )
...
PR Close #23687
2018-05-03 16:05:34 -07:00
Igor Minar
947ea17a09
build: update the scripts/release/post-check script for 6.0.x
2018-05-03 15:38:52 -07:00
Igor Minar
a190c45a64
fix(aio): correct project id for deployment of archive sites
2018-05-03 15:05:38 -07:00
Brandon Roberts
902781803f
docs(aio): Upgrade server-side rendering example to Angular V6 ( #23649 )
...
PR Close #23649
2018-05-03 14:24:44 -07:00
jenniferfell
0d480ac0dc
docs: add new info about angular update policies and resources ( #23551 )
...
PR Close #23551
2018-05-03 14:24:31 -07:00
Vani
6934bf4863
docs: add information on when not to use tree-shakable providers ( #23634 )
...
PR Close #23634
2018-05-03 14:24:16 -07:00
Vani
7e7ea33fb0
docs: add doc to include updates to the index.html with the new ng add command ( #23616 )
...
PR Close #23616
2018-05-03 14:23:30 -07:00
Igor Minar
5bd8c6887e
docs: improve the GitHub README.md, update links, etc
2018-05-03 13:26:52 -07:00
Igor Minar
d28ab372c8
docs: add link to the v6 release announcement to our changelog
2018-05-03 13:26:46 -07:00
Igor Minar
d0ccf5f169
release: cut the v6.0.0 release
6.0.0
2018-05-03 12:17:26 -07:00
Igor Minar
ecde15298a
build: update to rxjs@6.0.0 ( #23679 )
...
PR Close #23679
2018-05-03 10:53:39 -07:00
George Kalpakas
983e5f2d7e
fix(aio): correctly route embedded live-example URLs from SW ( #23637 )
...
Partially addresses #23626 .
PR Close #23637
2018-05-02 15:55:23 -07:00
Ardeshir81
5fc4299e0a
refactor(aio): move right margin from .home
image to .home
anchor ( #23624 )
...
This makes the outline of `.home` symmetric.
PR Close #23624
2018-05-02 15:54:15 -07:00
Ardeshir81
1823d5dd1c
style(aio): add space between .home
and .hamburger
( #23624 )
...
When the `.hamburger` icon is clicked, it's background is drawn until
the very edge of `.home`'s image, leaving no space.
PR Close #23624
2018-05-02 15:54:15 -07:00
Camilo Giraldo
91d4da0d2f
docs: add missing link to bootstrapping section ( #23214 )
...
PR Close #23214
2018-05-02 15:53:02 -07:00
Brandon Roberts
22eb8e26fc
build(aio): align stackblitz files with Angular CLI V6 ( #23521 )
...
Also cleans up legacy references to `.angular-cli.json`
PR Close #23521
2018-05-02 15:00:57 -07:00
Anuj
f6002c1702
docs(forms): Fixed a typo in the reactive form (From 'address' to 'secretLairs') section ( #23221 )
...
PR Close #23221
2018-05-02 15:00:28 -07:00
Andrew Seguin
14138f6382
docs(elements): add intro connecting angular elements to custom elements ( #23638 )
...
PR Close #23638
2018-05-02 14:57:20 -07:00
Sarun Intaralawan
f11daa2031
docs(aio): update Egghead.io URL ( #23598 )
...
Closes #23597
PR Close #23598
2018-05-01 10:27:16 -07:00
George Kalpakas
31a435ef5b
docs: fix typo in tag name (my-child
--> app-child
) ( #23606 )
...
Fixes #23599
PR Close #23606
2018-05-01 10:26:50 -07:00
Olivier Combe
3e92b22258
test: add i18n to cli-hello-world integration test ( #23527 )
...
PR Close #23527
2018-04-27 11:26:50 -07:00
Bennett Hardwick
2e5457c824
docs(aio): update docs error in guide/http ( #23567 )
...
Updates documentation to include examples for both req.flush and
req.error in http testing examples.
PR Close #23567
2018-04-27 11:26:27 -07:00
George Kalpakas
1ab5fba92e
build(aio): add support for faster, unoptimized serve
( #23569 )
...
When running `yarn start` and `yarn serve-and-sync`, we are usually
more interested in faster re-build times than optimized builds. This was
also the behavior, before upgrading to @angular/cli@6 (fc5af69fb).
This commit introduces a new configuration (`fast`), which is used by
`yarn start` and `yarn serve-and-sync` to restore the faster,
unoptimized builds.
Other commands, such as `ng serve` and `ng e2e`, remain unchanged (using
slower, optimized builds).
PR Close #23569
2018-04-27 11:26:22 -07:00
Judy Bogart
e1e57ddaa7
docs: correct more typos ( #23565 )
...
PR Close #23565
2018-04-27 11:26:17 -07:00
Judy Bogart
ee7cb48877
docs: correct typos ( #23565 )
...
PR Close #23565
2018-04-27 11:26:10 -07:00
Judy Bogart
a30c57090a
docs: correct node.js version and usage ( #23565 )
...
PR Close #23565
2018-04-27 11:26:04 -07:00
Brandon Roberts
8a49ec4f27
ci: add Brandon Roberts as an aio approver ( #23417 )
...
PR Close #23417
2018-04-27 11:25:59 -07:00
Vikram Subramanian
697b6c040c
fix(core): avoid eager providers re-initialization ( #23559 )
...
Fix a corner case where eager providers were getting constructed twice if the provider was requested before the initialization of the NgModule is complete.
PR Close #23559
2018-04-27 11:25:47 -07:00
Igor Minar
4008e36e80
release: cut the v6.0.0-rc.6 release
6.0.0-rc.6
2018-04-27 10:47:56 -07:00
Igor Minar
e47bb52084
Revert "refactor(core): tree-shake application_module providers ( #23477 )"
...
This reverts commit ac2b530f4b6b273eb0cf96753302f07d62ce6c0c.
The change is breaking targets in g3 see cl/194336387.
2018-04-27 07:13:56 -07:00
Matias Niemelä
ac2b530f4b
refactor(core): tree-shake application_module providers ( #23477 )
...
PR Close #23477
2018-04-25 15:54:41 -07:00