cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
12,891 Commits 56 Branches 477 Tags
Commit Graph

174 Commits

Author SHA1 Message Date
John Reese
3b1e539bab docs(forms): fix small typo in forms documentation (#29370) 
PR Close #29370
 2019-03-19 13:11:11 -04:00
Greg Magolan
ea495d958f build: rules_nodejs 0.26.0 & use @npm instead of @ngdeps now that downstream angular build uses angular bundles (#29063) 
* removed /tools/http_server and uses http_server from rules_nodejs
* updated bazel schematics to use angular bundles

PR Close #29063
 2019-03-07 08:57:24 -08:00
Rado Kirov
b06847f43d refactor: Consistently use index access on index signature types. (#28937) 
This change helps highlight certain misoptimizations with Closure
compiler. It is also stylistically preferable to consistently use index
access on index sig types.

Roughly, when one sees '.foo' they know it is always checked for typos
in the prop name by the type system (unless 'any'), while "['foo']" is
always not.

Once all angular repos are conforming this will become a tsetse.info
check, enforced by bazel.

PR Close #28937
 2019-02-28 02:52:19 -08:00
Greg Magolan
3eb327b67b build(bazel): do not build rxjs from source under Bazel (#28869) 
PR Close #28869
 2019-02-21 08:05:25 -08:00
Paul Gschwendtner
e2b3cc8118 build: remove unused rollup.config.js files (#28646) 
Since we build and publish the individual packages
using Bazel and `build.sh` has been removed, we can
safely remove the `rollup.config.js` files which are no
longer needed because the `ng_package` bazel rule
automatically handles the rollup settings and globals.

PR Close #28646
 2019-02-14 19:29:22 +00:00
Paul Gschwendtner
71b66fb862 build: run offline_compiler_test using bazel (#28191) 
PR Close #28191
 2019-01-28 20:07:23 -08:00
Alex Eagle
cf82fbceba build: set a default module_name for ts_library rules (#28051) (#28241) 
PR Close #28051

PR Close #28241
 2019-01-25 12:52:27 -08:00
Pete Bacon Darwin
47840bee71 docs(forms): fix up @see tags for AbstractContol (#28069) 
PR Close #28069
 2019-01-16 11:56:50 -08:00
Ivan Tham
12dd552fcd docs(forms): remove duplicated link (#27884) 
PR Close #27884
 2019-01-16 11:55:45 -08:00
Fabian Wiles
1b0b36d143 fix(forms): match getError and hasError to get method signature (#20211) 
Internally getError and hasError call the AbstractControl#get method which takes  `path: Array<string | number> | string` as input, since there are different ways to traverse the AbstractControl tree.
This change matches the method signitures of all methods that use this.

PR Close #20211
 2019-01-03 10:16:06 -08:00
Kara Erickson
e268a0579a docs(forms): update desc for hasError and getError (#27861) 
This commit adds docs for the changes made in #20211.

Closes #19734.

PR Close #27861
 2019-01-03 10:15:23 -08:00
jnizet
bba5e2632e docs(forms): clarify the pattern validator behavior (#27560) 
PR Close #27560
 2018-12-21 15:12:31 -05:00
Brandon Roberts
a433baf99a docs(forms): update API reference for validator directives (#26926) 
PR Close #26926
 2018-12-17 16:45:35 -08:00
Alex Eagle
d32939d51a build: restrict visibility of npm_package targets (#27611) 
dependencies on these cause very long rebuilds which have to re-package angular.
Such tests belong in the integration/ folder

PR Close #27611
 2018-12-14 10:20:40 -08:00
cexbrayat
b0c75611d6 fix(forms): typed argument for FormBuilder group (#26985) 
PR Close #26985
 2018-12-07 09:30:07 -08:00
Igor Minar
1b84b11cf5 Revert "fix(forms): apply unicode flag to pattern attribute when supported (#20819)" (#27375) 
This reverts commit 3c34b8b4f1ad32aef1b2e5213b6236c54ad93416.

breaks google3 see http://cl/223526995

PR Close #27375
 2018-11-30 10:49:27 -08:00
Igor Minar
63e125986c Revert "test(forms): add test on applying unicode flag (#20819)" (#27375) 
This reverts commit 619b8ab8220a7bc87a512d597c19a063d0ca5fa2.

breaks google3 see http://cl/223526995

PR Close #27375
 2018-11-30 10:49:27 -08:00
Igor Minar
1439071b7e Revert "docs(forms): take words suggestion (#20819)" (#27375) 
This reverts commit e024f2f8b76a2a4eb6511807a7bf3091899e9a46.

breaks google3 see http://cl/223526995

PR Close #27375
 2018-11-30 10:49:27 -08:00
Brandon Roberts
c331fc6f0c docs(forms): update API reference for common APIs and template-driven directives (#27033) 
PR Close #27033
 2018-11-29 21:33:07 -08:00
Igor Minar
e024f2f8b7 docs(forms): take words suggestion (#20819) 
Co-Authored-By: JLHwung <JLHwung@users.noreply.github.com>

PR Close #20819
 2018-11-29 21:19:37 -08:00
Huáng Jùnliàng
619b8ab822 test(forms): add test on applying unicode flag (#20819) 
PR Close #20819
 2018-11-29 21:19:37 -08:00
Huáng Jùnliàng
3c34b8b4f1 fix(forms): apply unicode flag to pattern attribute when supported (#20819) 
Both Firefox and Chrome have applied unicode flag to the `pattern` content attribute of INPUT element.
See https://www.chromestatus.com/feature/4753420745441280

PR Close #20819
 2018-11-29 21:19:37 -08:00
Miško Hevery
ca40565f9a fix(ivy): hack implementation of host styles (#27180) 
PR Close #27180
 2018-11-20 11:43:29 -08:00
Nick Tobolski
975c269752 docs(forms): language correction (#27177) 
Word missing from docs
PR Close #27177
 2018-11-20 10:46:34 -08:00
Huáng Jùnliàng
34306c356e docs(forms): close markdown backticks (#27189) 
PR Close #27189
 2018-11-20 10:45:16 -08:00
Kara Erickson
1810cdf2c3 fix(ivy): compiler should generate restoreView() for local refs in listeners (#27034) 
PR Close #27034
 2018-11-12 12:50:58 -08:00
Brandon Roberts
99c5db1fb1 docs(forms): update API reference for value accessors (#26946) 
PR Close #26946
 2018-11-12 12:48:33 -08:00
Kara Erickson
78b6f88cb3 fix(ivy): TestBed should use an NgZone (#27015) 
PR Close #27015
 2018-11-09 09:56:36 -08:00
Kara Erickson
552836ebf0 fix(ivy): merged host bindings functions should take superclass hostVars into account (#27013) 
PR Close #27013
 2018-11-09 09:55:47 -08:00
Kara Erickson
9e26216c40 fix(ivy): compiler should generate bindings to host attrs properly (#26973) 
PR Close #26973
 2018-11-07 11:09:31 -08:00
Kara Erickson
a4398aa17f docs(forms): update description for FormBuilder.group (#26970) 
PR Close #26970
 2018-11-07 10:39:12 -08:00
Kara Erickson
3ca1a57f81 test(ivy): run forms tests with ivy on ci (#26968) 
PR Close #26968
 2018-11-06 15:09:35 -08:00
Brandon Roberts
099d1a67a0 docs(forms): update reactive form directives API reference (#26823) 
PR Close #26823
 2018-11-05 15:11:42 -08:00
Misko Hevery
7d2a746090 build: remove ivy JIT mode (#26863) 
PR Close #26863
 2018-11-02 15:44:05 -07:00
Lars Gyrup Brink Nielsen
e9e804fb02 feat(forms): add updateOn option to FormBuilder (#24599) 
PR Close #24599
 2018-11-01 15:31:11 -07:00
Igor Minar
ee0b857172 build: rename the ivy compile mode 'local' to 'aot' (#26686) 
PR Close #26686
 2018-10-23 14:14:49 -07:00
Igor Minar
4237c34c78 test(ivy): mark failing test targets with fixme-ivy-jit and fixme-ivy-local tags (#26471) 
We are close enough to blacklist a few test targets, rather than whitelist targets to run...

Because bazel rules can be composed of other rules that don't inherit tags automatically,
I had to explicitly mark all of our ts_library and ng_module targes with "ivy-local" and
"ivy-jit" tags so that we can create a query that excludes all fixme- tagged targets even
if those targets are composed of other targets that don't inherit this tag.

This is the updated overview of ivy related bazel tags:

- ivy-only: target that builds or runs only under ivy
- fixme-ivy-jit: target that doesn't yet build or run under ivy with --compile=jit
- fixme-ivy-local: target that doesn't yet build or run under ivy with --compile=local
- no-ivy-jit: target that is not intended to build or run under ivy with --compile=jit
- no-ivy-local: target that is not intended to build or run under ivy with --compile=local

PR Close #26471
 2018-10-23 08:57:42 -07:00
Pete Bacon Darwin
982bc7f2aa docs: update forms with @publicApi tags (#26595) 
PR Close #26595
 2018-10-19 14:35:53 -07:00
Pete Bacon Darwin
24521f549c docs: convert all @experimental tags to @publicApi tags (#26595) 
PR Close #26595
 2018-10-19 14:35:52 -07:00
Brandon Roberts
ebd01e8e79 docs: more form overview edits (#25663) 
PR Close #25663
 2018-09-25 18:48:15 -07:00
Brandon Roberts
04dfca41f4 docs(forms): add package overview for forms (#25663) 
PR Close #25663
 2018-09-25 18:48:15 -07:00
Frederik Schlemmer
1e02cd9961 docs: Fixes typo in FormArray (#26031) 
PR Close #26031
 2018-09-24 09:14:07 -07:00
Pete Bacon Darwin
7d39bc68fb docs(forms): move extended text to @usageNotes (#26039) 
Headings are not allowed in the basic description block.

PR Close #26039
 2018-09-24 09:11:02 -07:00
Pete Bacon Darwin
927323f24e docs: add missing @ngModule tags (#25734) 
PR Close #25734
 2018-09-19 16:18:24 -07:00
Brandon Roberts
a9a81f91cf docs(forms): update form apis based on review feedback (#25724) 
PR Close #25724
 2018-09-19 16:09:00 -07:00
Brandon Roberts
07c10e2844 docs(forms): update API reference for forms interfaces and abstract classes (#25724) 
PR Close #25724
 2018-09-19 16:09:00 -07:00
Judy Bogart
dd5e35ee67 docs: add ngmodule api doc (#25618) 
PR Close #25618
 2018-09-19 10:40:58 -07:00
Alex Eagle
cbbad1b791 refactor(ivy): pre-factor: set explicit type parameters for ModuleWithProviders (#25970) 
Ivy depends on having the generic type token later when reading the ModuleWithProviders from a .d.ts file.

PR Close #25970
 2018-09-18 13:28:44 -07:00
George Wilde
ddd3bf83c7 docs(forms): change documentation of the FormGroup patchValue method (#25901) 
Improve the grammar of the description to make it more readable.
PR Close #25901
 2018-09-18 13:08:05 -07:00
Greg Magolan
b99d7ed5bf build(bazel): update to rules_typescript 0.17.0 & rules_nodejs 0.13.4 (#25920) 
PR Close #25920
 2018-09-18 13:05:38 -07:00