cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
8,773 Commits 56 Branches 477 Tags
Commit Graph

40 Commits

Author SHA1 Message Date
Chuck Jazdzewski
d7eac7ee56 Revert "fix(router): navigating to the current location works (#19463)" 
This reverts commit 43c5b638b96a0c63f041a0b31e4c646ead72341b.
 2017-10-09 16:38:12 -07:00
Chuck Jazdzewski
d53b96f2a2 Revert "fix(router): do not call location.go when skipping a navigation (#19463)" 
This reverts commit 66515412308138ad083bdd91ab2e80cd2bdf7fac.
 2017-10-09 16:37:31 -07:00
vsavkin
6651541230 fix(router): do not call location.go when skipping a navigation (#19463) 
Closes #18036

PR Close #19463
 2017-10-09 11:45:13 -07:00
vsavkin
43c5b638b9 fix(router): navigating to the current location works (#19463) 
Closes #13340

PR Close #19463
 2017-10-09 11:45:13 -07:00
Chuck Jazdzewski
8e5b582b61 Revert "fix(router): navigating to the current location works (#19463)" 
This reverts commit b67d574a9562d76ab0a838f4d1b42501e5c5f09b.
 2017-10-06 18:15:19 -07:00
Chuck Jazdzewski
0cc87c5ba1 Revert "fix(router): do not call location.go when skipping a navigation (#19463)" 
This reverts commit fdfa31798befb57d90770956cc95511d9b3b7bd1.
 2017-10-06 18:15:16 -07:00
vsavkin
fdfa31798b fix(router): do not call location.go when skipping a navigation (#19463) 
Closes #18036

PR Close #19463
 2017-10-06 15:35:25 -07:00
vsavkin
b67d574a95 fix(router): navigating to the current location works (#19463) 
Closes #13340

PR Close #19463
 2017-10-06 15:35:24 -07:00
Victor Savkin
a9d32a3f89 fix(router): resolve and guards should be able to reject with null and undefined (#19418) 
Closes #17148
 2017-09-28 11:06:08 -07:00
Yuan Gao
549f2254b4 refactor(core): remove getters for packages/animations, language-service, platform-browser, router (#19151) 
PR Close #19151
 2017-09-20 12:38:37 -07:00
Jason Aden
8f7915022c feat(router): add ActivationStart/End events 2017-09-08 13:24:26 -04:00
Jason Aden
66f0ab0371 fix(router): adjust ChildActivation events to only fire when the child is actually changing (#19043) 
* The problem was with the `fireChildActivationStart` function. It was taking a `path` param, which was an
array of `ActivatedRouteSnapshot`s. The function was being fired for each piece of the route that was being
activated. This resulted in far too many `ChildActivationStart` events being fired, and being fired on routes
that weren't actually getting activated. This change fires the event only for those routes that are actually
being activated.

fixes #18942

PR Close #19043
 2017-09-05 15:46:29 -05:00
Jason Aden
dce36751f5 refactor(router): remove RouteEvent base class (#19043) 
* Introduced with #18407, `RouteEvents` don't actually have a common constructor. Reverting here to be able to add new functionality to ChildActivation events.

PR Close #19043
 2017-09-05 15:46:29 -05:00
Chuck Jazdzewski
3a227a1f6f refactor(router): compile router cleanly with TypeScript 2.4 (#18465) 2017-08-02 17:32:02 -07:00
Jason Aden
49cd8513e4 feat(router): add events tracking activation of individual routes 
* Adds `ChildActivationStart` and `ChildActivationEnd`
* Adds test to verify the PreActivation phase of routing
 2017-08-01 10:44:00 -07:00
Victor Berchet
9479a106bb build: enable TSLint on the packages folder 2017-07-31 15:47:57 -07:00
Dzmitry Shylovich
086f4aa72c fix(router): child CanActivate guard should wait for parent to complete (#18110) 
Closes #15670

PR Close #18110
 2017-07-26 17:11:22 -05:00
Roy Ling
e20cfe1bbc fix(router): canDeactivate guards should run from bottom to top 
Closes #15657.
 2017-07-18 10:04:39 -07:00
Dzmitry Shylovich
eb6fb5f87e fix(router): should navigate to the same url when config changes 
Closes #15535
 2017-07-18 10:04:11 -07:00
Dzmitry Shylovich
ad3029e786 fix(router): should run resolvers for the same route concurrently 
Fixes #14279
 2017-07-18 10:03:33 -07:00
Jason Aden
8a1a989a1c feat(router): add router-level events for GuardsCheck and Resolve (#17601) 2017-07-01 10:30:17 -07:00
Alex Rickabaugh
c59c390cdc fix: argument destructuring sometimes breaks strictNullChecks 
Destructuring of the form:

function foo({a, b}: {a?, b?} = {})

breaks strictNullChecks, due to the TypeScript bug https://github.com/microsoft/typescript/issues/10078.
This change eliminates usage of destructuring in function argument lists in cases where it would leak
into the public API .d.ts.
 2017-06-20 12:56:08 -07:00
Victor Berchet
5d4f5434fd refactor(router): don't run the change detection every time an outlet is activated 
fix(router): inside on push // SQUASH after review
 2017-05-19 11:55:15 -07:00
Victor Berchet
81ca51a8f0 refactor(router): cleanup, simplification 2017-05-19 11:55:15 -07:00
Matias Niemelä
86b7bd9c8e revert: refactor(router): cleanup, simplification 
This reverts commit 44d48d9d7aa10bbf03c412ce7e59821c748b5d2d.
 2017-05-18 11:57:22 -07:00
Matias Niemelä
a0a6029915 revert: refactor(router): don't run the change detection every time an outlet is activated 
This reverts commit 198edb31093ffdecfd13aed17967fb02e650cffe.
 2017-05-18 11:57:22 -07:00
Victor Berchet
198edb3109 refactor(router): don't run the change detection every time an outlet is activated 2017-05-17 19:32:04 -07:00
Victor Berchet
44d48d9d7a refactor(router): cleanup, simplification 2017-05-17 19:32:04 -07:00
Miško Hevery
a0d124bd91 fix(router): relax nullability requirements 2017-04-18 12:07:33 -07:00
Miško Hevery
bc431888f3 fix(router): Update types for TypeScript nullability support 
This reverts commit ea8ffc984136ef4d32b6858fe35e69cc9fced021.
 2017-04-18 12:07:33 -07:00
Tobias Bosch
ea8ffc9841 Revert "fix(router): Update types for TypeScript nullability support" 
This reverts commit 56c46d70f7b3cb308d658224682d739d4f9b5a2a.

Broke in G3.
 2017-04-17 09:56:09 -07:00
Miško Hevery
56c46d70f7 fix(router): Update types for TypeScript nullability support 2017-04-14 14:31:17 -07:00
Victor Berchet
ea4afebeb9 refactor(router): drop the InternalRoute interface 2017-04-14 09:08:13 -07:00
Dzmitry Shylovich
886cca028f refactor(router): misc refactoring 2017-04-14 09:08:13 -07:00
Victor Berchet
d58a242fe7 refactor(router): cleanup & simplification (#15436) 2017-03-29 09:44:04 -07:00
Dzmitry Shylovich
f368381d12 fix(router): should run CanActivate after CanDeactivate guards 
Closes #14059
Closes #15467
 2017-03-28 15:51:33 -07:00
Dzmitry Shylovich
606b8fafb0 refactor(router): use object spread operator instead of merge fn 2017-03-28 09:38:58 -07:00
Victor Berchet
a9d5de0e56 refactor(router): misc minor updates 2017-03-20 09:19:32 -07:00
Victor Berchet
13686bb518 fix: element injector vs module injector (#15044) 
fixes #12869
fixes #12889
fixes #13885
fixes #13870

Before this change there was a single injector tree.
Now we have 2 injector trees, one for the modules and one for the components.
This fixes lazy loading modules.

See the design docs for details:
https://docs.google.com/document/d/1OEUIwc-s69l1o97K0wBd_-Lth5BBxir1KuCRWklTlI4

BREAKING CHANGES

`ComponentFactory.create()` takes an extra optional `NgModuleRef` parameter.
No change should be required in user code as the correct module will be used
when none is provided

DEPRECATIONS

The following methods were used internally and are no more required:
- `RouterOutlet.locationFactoryResolver`
- `RouterOutlet.locationInjector`
 2017-03-14 16:26:17 -07:00
Jason Aden
3e51a19983 refactor: move angular source to /packages rather than modules/@angular 2017-03-08 16:29:27 -08:00