21da0346c7
In Ivy, Angular decorators are compiled into static fields that are inserted into a class declaration in a TypeScript transform. When targeting Closure compiler such fields need to be annotated with `@nocollapse` to prevent them from being lifted from a static field into a variable, as that would prevent the Ivy runtime from being able to find the compiled definitions. Previously, there was a bug in TypeScript where synthetic comments added in a transform would not be emitted at all, so as a workaround a global regex-replace was done in the emit's `writeFile` callback that would add the `@nocollapse` annotation to all static Ivy definition fields. This approach is no longer possible when ngtsc is running as TypeScript plugin, as a plugin cannot control emit behavior. The workaround is no longer necessary, as synthetic comments are now properly emitted, likely as of https://github.com/microsoft/TypeScript/pull/22141 which has been released with TypeScript 2.8. This change is required for running ngtsc as TypeScript plugin in Bazel's `ts_library` rule, to move away from the custom `ngc_wrapped` approach. Resolves FW-1952 PR Close #35932
80 lines
3.6 KiB
TypeScript
80 lines
3.6 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright Google Inc. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by an MIT-style license that can be
|
|
* found in the LICENSE file at https://angular.io/license
|
|
*/
|
|
|
|
import {GeneratedFile} from '@angular/compiler';
|
|
import * as ts from 'typescript';
|
|
|
|
import {TypeScriptNodeEmitter} from './node_emitter';
|
|
import {GENERATED_FILES} from './util';
|
|
|
|
function getPreamble(original: string) {
|
|
return `/**
|
|
* @fileoverview This file was generated by the Angular template compiler. Do not edit.
|
|
* ${original}
|
|
* @suppress {suspiciousCode,uselessCode,missingProperties,missingOverride,checkTypes,extraRequire}
|
|
* tslint:disable
|
|
*/`;
|
|
}
|
|
|
|
/**
|
|
* Returns a transformer that does two things for generated files (ngfactory etc):
|
|
* - adds a fileoverview JSDoc comment containing Closure Compiler specific "suppress"ions in JSDoc.
|
|
* The new comment will contain any fileoverview comment text from the original source file this
|
|
* file was generated from.
|
|
* - updates generated files that are not in the given map of generatedFiles to have an empty
|
|
* list of statements as their body.
|
|
*/
|
|
export function getAngularEmitterTransformFactory(
|
|
generatedFiles: Map<string, GeneratedFile>, program: ts.Program,
|
|
annotateForClosureCompiler: boolean): () => (sourceFile: ts.SourceFile) => ts.SourceFile {
|
|
return function() {
|
|
const emitter = new TypeScriptNodeEmitter(annotateForClosureCompiler);
|
|
return function(sourceFile: ts.SourceFile): ts.SourceFile {
|
|
const g = generatedFiles.get(sourceFile.fileName);
|
|
const orig = g && program.getSourceFile(g.srcFileUrl);
|
|
let originalComment = '';
|
|
if (orig) originalComment = getFileoverviewComment(orig);
|
|
const preamble = getPreamble(originalComment);
|
|
if (g && g.stmts) {
|
|
const orig = program.getSourceFile(g.srcFileUrl);
|
|
let originalComment = '';
|
|
if (orig) originalComment = getFileoverviewComment(orig);
|
|
const [newSourceFile] = emitter.updateSourceFile(sourceFile, g.stmts, preamble);
|
|
return newSourceFile;
|
|
} else if (GENERATED_FILES.test(sourceFile.fileName)) {
|
|
// The file should be empty, but emitter.updateSourceFile would still add imports
|
|
// and various minutiae.
|
|
// Clear out the source file entirely, only including the preamble comment, so that
|
|
// ngc produces an empty .js file.
|
|
return ts.updateSourceFileNode(
|
|
sourceFile, [emitter.createCommentStatement(sourceFile, preamble)]);
|
|
}
|
|
return sourceFile;
|
|
};
|
|
};
|
|
}
|
|
|
|
/**
|
|
* Parses and returns the comment text (without start and end markers) of a \@fileoverview comment
|
|
* in the given source file. Returns the empty string if no such comment can be found.
|
|
*/
|
|
function getFileoverviewComment(sourceFile: ts.SourceFile): string {
|
|
const trivia = sourceFile.getFullText().substring(0, sourceFile.getStart());
|
|
const leadingComments = ts.getLeadingCommentRanges(trivia, 0);
|
|
if (!leadingComments || leadingComments.length === 0) return '';
|
|
const comment = leadingComments[0];
|
|
if (comment.kind !== ts.SyntaxKind.MultiLineCommentTrivia) return '';
|
|
// Only comments separated with a \n\n from the file contents are considered file-level comments
|
|
// in TypeScript.
|
|
if (sourceFile.getFullText().substring(comment.end, comment.end + 2) !== '\n\n') return '';
|
|
const commentText = sourceFile.getFullText().substring(comment.pos, comment.end);
|
|
// Closure Compiler ignores @suppress and similar if the comment contains @license.
|
|
if (commentText.indexOf('@license') !== -1) return '';
|
|
return commentText.replace(/^\/\*\*/, '').replace(/ ?\*\/$/, '');
|
|
}
|