angular/packages/compiler-cli/ngcc/src/writing/package_json_updater.ts
George Kalpakas 93ffc67bfb fix(ngcc): update package.json deterministically (#34870)
Ngcc adds properties to the `package.json` files of the entry-points it
processes to mark them as processed for a format and point to the
created Ivy entry-points (in case of `--create-ivy-entry-points`). When
running ngcc in parallel mode (which is the default for the standalone
ngcc command), multiple formats can be processed simultaneously for the
same entry-point and the order of completion is not deterministic.

Previously, ngcc would append new properties at the end of the target
object in `package.json` as soon as the format processing was completed.
As a result, the order of properties in the resulting `package.json`
(when processing multiple formats for an entry-point in parallel) was
not deterministic. For tools that use file hashes for caching purposes
(such as Bazel), this lead to a high probability of cache misses.

This commit fixes the problem by ensuring that the position of
properties added to `package.json` files is deterministic and
independent of the order in which each format is processed.

Jira issue: [FW-1801](https://angular-team.atlassian.net/browse/FW-1801)

Fixes #34635

PR Close #34870
2020-01-23 10:16:35 -08:00

216 lines
8.0 KiB
TypeScript

/**
* @license
* Copyright Google Inc. All Rights Reserved.
*
* Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.io/license
*/
import {AbsoluteFsPath, FileSystem, dirname} from '../../../src/ngtsc/file_system';
import {JsonObject, JsonValue} from '../packages/entry_point';
export type PackageJsonChange = [string[], JsonValue, PackageJsonPropertyPositioning];
export type PackageJsonPropertyPositioning = 'unimportant' | 'alphabetic' | {before: string};
export type WritePackageJsonChangesFn =
(changes: PackageJsonChange[], packageJsonPath: AbsoluteFsPath, parsedJson?: JsonObject) =>
void;
/**
* A utility object that can be used to safely update values in a `package.json` file.
*
* Example usage:
* ```ts
* const updatePackageJson = packageJsonUpdater
* .createUpdate()
* .addChange(['name'], 'package-foo')
* .addChange(['scripts', 'foo'], 'echo FOOOO...', 'unimportant')
* .addChange(['dependencies', 'baz'], '1.0.0', 'alphabetic')
* .addChange(['dependencies', 'bar'], '2.0.0', {before: 'baz'})
* .writeChanges('/foo/package.json');
* // or
* // .writeChanges('/foo/package.json', inMemoryParsedJson);
* ```
*/
export interface PackageJsonUpdater {
/**
* Create a `PackageJsonUpdate` object, which provides a fluent API for batching updates to a
* `package.json` file. (Batching the updates is useful, because it avoids unnecessary I/O
* operations.)
*/
createUpdate(): PackageJsonUpdate;
/**
* Write a set of changes to the specified `package.json` file (and optionally a pre-existing,
* in-memory representation of it).
*
* @param changes The set of changes to apply.
* @param packageJsonPath The path to the `package.json` file that needs to be updated.
* @param parsedJson A pre-existing, in-memory representation of the `package.json` file that
* needs to be updated as well.
*/
writeChanges(
changes: PackageJsonChange[], packageJsonPath: AbsoluteFsPath, parsedJson?: JsonObject): void;
}
/**
* A utility class providing a fluent API for recording multiple changes to a `package.json` file
* (and optionally its in-memory parsed representation).
*
* NOTE: This class should generally not be instantiated directly; instances are implicitly created
* via `PackageJsonUpdater#createUpdate()`.
*/
export class PackageJsonUpdate {
private changes: PackageJsonChange[] = [];
private applied = false;
constructor(private writeChangesImpl: WritePackageJsonChangesFn) {}
/**
* Record a change to a `package.json` property.
*
* If the ancestor objects do not yet exist in the `package.json` file, they will be created. The
* positioning of the property can also be specified. (If the property already exists, it will be
* moved accordingly.)
*
* NOTE: Property positioning is only guaranteed to be respected in the serialized `package.json`
* file. Positioning will not be taken into account when updating in-memory representations.
*
* NOTE 2: Property positioning only affects the last property in `propertyPath`. Ancestor
* objects' positioning will not be affected.
*
* @param propertyPath The path of a (possibly nested) property to add/update.
* @param value The new value to set the property to.
* @param position The desired position for the added/updated property.
*/
addChange(
propertyPath: string[], value: JsonValue,
positioning: PackageJsonPropertyPositioning = 'unimportant'): this {
this.ensureNotApplied();
this.changes.push([propertyPath, value, positioning]);
return this;
}
/**
* Write the recorded changes to the associated `package.json` file (and optionally a
* pre-existing, in-memory representation of it).
*
* @param packageJsonPath The path to the `package.json` file that needs to be updated.
* @param parsedJson A pre-existing, in-memory representation of the `package.json` file that
* needs to be updated as well.
*/
writeChanges(packageJsonPath: AbsoluteFsPath, parsedJson?: JsonObject): void {
this.ensureNotApplied();
this.writeChangesImpl(this.changes, packageJsonPath, parsedJson);
this.applied = true;
}
private ensureNotApplied() {
if (this.applied) {
throw new Error('Trying to apply a `PackageJsonUpdate` that has already been applied.');
}
}
}
/** A `PackageJsonUpdater` that writes directly to the file-system. */
export class DirectPackageJsonUpdater implements PackageJsonUpdater {
constructor(private fs: FileSystem) {}
createUpdate(): PackageJsonUpdate {
return new PackageJsonUpdate((...args) => this.writeChanges(...args));
}
writeChanges(
changes: PackageJsonChange[], packageJsonPath: AbsoluteFsPath,
preExistingParsedJson?: JsonObject): void {
if (changes.length === 0) {
throw new Error(`No changes to write to '${packageJsonPath}'.`);
}
// Read and parse the `package.json` content.
// NOTE: We are not using `preExistingParsedJson` (even if specified) to avoid corrupting the
// content on disk in case `preExistingParsedJson` is outdated.
const parsedJson =
this.fs.exists(packageJsonPath) ? JSON.parse(this.fs.readFile(packageJsonPath)) : {};
// Apply all changes to both the canonical representation (read from disk) and any pre-existing,
// in-memory representation.
for (const [propPath, value, positioning] of changes) {
if (propPath.length === 0) {
throw new Error(`Missing property path for writing value to '${packageJsonPath}'.`);
}
applyChange(parsedJson, propPath, value, positioning);
if (preExistingParsedJson) {
// No need to take property positioning into account for in-memory representations.
applyChange(preExistingParsedJson, propPath, value, 'unimportant');
}
}
// Ensure the containing directory exists (in case this is a synthesized `package.json` due to a
// custom configuration) and write the updated content to disk.
this.fs.ensureDir(dirname(packageJsonPath));
this.fs.writeFile(packageJsonPath, `${JSON.stringify(parsedJson, null, 2)}\n`);
}
}
// Helpers
export function applyChange(
ctx: JsonObject, propPath: string[], value: JsonValue,
positioning: PackageJsonPropertyPositioning): void {
const lastPropIdx = propPath.length - 1;
const lastProp = propPath[lastPropIdx];
for (let i = 0; i < lastPropIdx; i++) {
const key = propPath[i];
const newCtx = ctx.hasOwnProperty(key) ? ctx[key] : (ctx[key] = {});
if ((typeof newCtx !== 'object') || (newCtx === null) || Array.isArray(newCtx)) {
throw new Error(`Property path '${propPath.join('.')}' does not point to an object.`);
}
ctx = newCtx;
}
ctx[lastProp] = value;
positionProperty(ctx, lastProp, positioning);
}
function movePropBefore(ctx: JsonObject, prop: string, isNextProp: (p: string) => boolean): void {
const allProps = Object.keys(ctx);
const otherProps = allProps.filter(p => p !== prop);
const nextPropIdx = otherProps.findIndex(isNextProp);
const propsToShift = (nextPropIdx === -1) ? [] : otherProps.slice(nextPropIdx);
movePropToEnd(ctx, prop);
propsToShift.forEach(p => movePropToEnd(ctx, p));
}
function movePropToEnd(ctx: JsonObject, prop: string): void {
const value = ctx[prop];
delete ctx[prop];
ctx[prop] = value;
}
function positionProperty(
ctx: JsonObject, prop: string, positioning: PackageJsonPropertyPositioning): void {
switch (positioning) {
case 'alphabetic':
movePropBefore(ctx, prop, p => p > prop);
break;
case 'unimportant':
// Leave the property order unchanged; i.e. newly added properties will be last and existing
// ones will remain in their old position.
break;
default:
if ((typeof positioning !== 'object') || (positioning.before === undefined)) {
throw new Error(
`Unknown positioning (${JSON.stringify(positioning)}) for property '${prop}'.`);
}
movePropBefore(ctx, prop, p => p === positioning.before);
break;
}
}