
Previously, `validate-commit-message` would treat `fixup! `-prefixed commits like this: - It would strip the `fixup! ` prefix. - It would validate the rest of the commit message header as any other commit. However, fixup commits are special in that they need to exactly match an earlier commit message header (sans the `fixup! ` prefix) in order for git to treat them correctly. Otherwise, they will not be squashed into the original commits and will be merged as is. Fixup commits can end up not matching their original commit for several reasons (e.g. accidental typo, changing the original commit message, etc.). This commit prevents invalid fixup commits to pass validation by ensuring that they match an earlier (unmerged) commit (i.e. a commit between the current HEAD and the BASE commit). NOTE: This new behavior is currently not activated in the pre-commit git hook, that is used to validate commit messages (because the preceding, unmerged commits are not available there). It _is_ activated in `gulp validate-commit-message`, which is run as part of the `lint` job on CI and thus will detect invalid commits, before their getting merged. PR Close #32023
Gulp Tasks folder
This folder contains one file for each task (or group of related tasks) for the project's gulpfile. The dependencies between the tasks is kept in the gulpfile.
Task File Structure
Each task is defined by a factory function that accepts gulp
as a parameter.
Each file exports either one factory or an object of factories.
E.g. The build.js
file contains only one task:
module.exports = (gulp) => (done) => {
...
};
E.g. The format.js
file contains two tasks:
module.exports = {
// Check source code for formatting errors (clang-format)
enforce: (gulp) => () => {
...
},
// Format the source code with clang-format (see .clang-format)
format: (gulp) => () => {
...
}
};
Loading Tasks
The tasks are loaded in the gulp file, by requiring them. There is a helper called loadTask(fileName, taskName)
will do this for us, where the taskName
is optional if the file only exports one task.
E.g. Loading the task that will run the build, from a task file that contains only one task.
gulp.task('build.sh', loadTask('build'));
E.g. Loading the task that will enforce formatting, from a task file that contains more than one task:
gulp.task('format:enforce', loadTask('format', 'enforce'));
E.g. Loading a task that has dependencies:
gulp.task('lint', ['format:enforce', 'tools:build'], loadTask('lint'));