c0d5684078
While `fixup! ` is fine, `squash! ` means that the commit message needs
tweaking, which cannot be done automatically during merging (i.e. it
should be done by the PR author).
Previously, `validate-commit-message` would always allow
`squash! `-prefixed commits, which would cause problems during merging.
This commit changes `validate-commit-message` to make it configurable
whether such commits are allowed and configures the
`gulp validate-commit-message` task, which is run as part of the `lint`
job on CI, to not allow them.
NOTE: This new check is disabled in the pre-commit git hook that is used
to validate commit messages, because these commits might still be
useful during development.
PR Close #32023
Gulp Tasks folder
This folder contains one file for each task (or group of related tasks) for the project's gulpfile. The dependencies between the tasks is kept in the gulpfile.
Task File Structure
Each task is defined by a factory function that accepts gulp as a parameter.
Each file exports either one factory or an object of factories.
E.g. The build.js file contains only one task:
module.exports = (gulp) => (done) => {
...
};
E.g. The format.js file contains two tasks:
module.exports = {
// Check source code for formatting errors (clang-format)
enforce: (gulp) => () => {
...
},
// Format the source code with clang-format (see .clang-format)
format: (gulp) => () => {
...
}
};
Loading Tasks
The tasks are loaded in the gulp file, by requiring them. There is a helper called loadTask(fileName, taskName)
will do this for us, where the taskName is optional if the file only exports one task.
E.g. Loading the task that will run the build, from a task file that contains only one task.
gulp.task('build.sh', loadTask('build'));
E.g. Loading the task that will enforce formatting, from a task file that contains more than one task:
gulp.task('format:enforce', loadTask('format', 'enforce'));
E.g. Loading a task that has dependencies:
gulp.task('lint', ['format:enforce', 'tools:build'], loadTask('lint'));