c387952739
Previously, the compiler performed an incremental build by analyzing and resolving all classes in the program (even unchanged ones) and then using the dependency graph information to determine which .js files were stale and needed to be re-emitted. This algorithm produced "correct" rebuilds, but the cost of re-analyzing the entire program turned out to be higher than anticipated, especially for component-heavy compilations. To achieve performant rebuilds, it is necessary to reuse previous analysis results if possible. Doing this safely requires knowing when prior work is viable and when it is stale and needs to be re-done. The new algorithm implemented by this commit is such: 1) Each incremental build starts with knowledge of the last known good dependency graph and analysis results from the last successful build, plus of course information about the set of files changed. 2) The previous dependency graph's information is used to determine the set of source files which have "logically" changed. A source file is considered logically changed if it or any of its dependencies have physically changed (on disk) since the last successful compilation. Any logically unchanged dependencies have their dependency information copied over to the new dependency graph. 3) During the `TraitCompiler`'s loop to consider all source files in the program, if a source file is logically unchanged then its previous analyses are "adopted" (and their 'register' steps are run). If the file is logically changed, then it is re-analyzed as usual. 4) Then, incremental build proceeds as before, with the new dependency graph being used to determine the set of files which require re-emitting. This analysis reuse avoids template parsing operations in many circumstances and significantly reduces the time it takes ngtsc to rebuild a large application. Future work will increase performance even more, by tackling a variety of other opportunities to reuse or avoid work. PR Close #34288
91 lines
3.4 KiB
TypeScript
91 lines
3.4 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright Google Inc. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by an MIT-style license that can be
|
|
* found in the LICENSE file at https://angular.io/license
|
|
*/
|
|
import {absoluteFrom} from '../../file_system';
|
|
import {runInEachFileSystem} from '../../file_system/testing';
|
|
import {NOOP_DEFAULT_IMPORT_RECORDER, ReferenceEmitter} from '../../imports';
|
|
import {DtsMetadataReader, LocalMetadataRegistry} from '../../metadata';
|
|
import {PartialEvaluator} from '../../partial_evaluator';
|
|
import {ClassDeclaration, TypeScriptReflectionHost, isNamedClassDeclaration} from '../../reflection';
|
|
import {LocalModuleScopeRegistry, MetadataDtsModuleScopeResolver} from '../../scope';
|
|
import {getDeclaration, makeProgram} from '../../testing';
|
|
import {DirectiveDecoratorHandler} from '../src/directive';
|
|
|
|
runInEachFileSystem(() => {
|
|
describe('DirectiveDecoratorHandler', () => {
|
|
let _: typeof absoluteFrom;
|
|
beforeEach(() => _ = absoluteFrom);
|
|
|
|
it('should use the `ReflectionHost` to detect class inheritance', () => {
|
|
const {program} = makeProgram([
|
|
{
|
|
name: _('/node_modules/@angular/core/index.d.ts'),
|
|
contents: 'export const Directive: any;',
|
|
},
|
|
{
|
|
name: _('/entry.ts'),
|
|
contents: `
|
|
import {Directive} from '@angular/core';
|
|
|
|
@Directive({selector: 'test-dir-1'})
|
|
export class TestDir1 {}
|
|
|
|
@Directive({selector: 'test-dir-2'})
|
|
export class TestDir2 {}
|
|
`,
|
|
},
|
|
]);
|
|
|
|
const checker = program.getTypeChecker();
|
|
const reflectionHost = new TestReflectionHost(checker);
|
|
const evaluator = new PartialEvaluator(reflectionHost, checker, /* dependencyTracker */ null);
|
|
const metaReader = new LocalMetadataRegistry();
|
|
const dtsReader = new DtsMetadataReader(checker, reflectionHost);
|
|
const scopeRegistry = new LocalModuleScopeRegistry(
|
|
metaReader, new MetadataDtsModuleScopeResolver(dtsReader, null), new ReferenceEmitter([]),
|
|
null);
|
|
const handler = new DirectiveDecoratorHandler(
|
|
reflectionHost, evaluator, scopeRegistry, NOOP_DEFAULT_IMPORT_RECORDER,
|
|
/* isCore */ false, /* annotateForClosureCompiler */ false);
|
|
|
|
const analyzeDirective = (dirName: string) => {
|
|
const DirNode = getDeclaration(program, _('/entry.ts'), dirName, isNamedClassDeclaration);
|
|
|
|
const detected =
|
|
handler.detect(DirNode, reflectionHost.getDecoratorsOfDeclaration(DirNode));
|
|
if (detected === undefined) {
|
|
throw new Error(`Failed to recognize @Directive (${dirName}).`);
|
|
}
|
|
|
|
const {analysis} = handler.analyze(DirNode, detected.metadata);
|
|
if (analysis === undefined) {
|
|
throw new Error(`Failed to analyze @Directive (${dirName}).`);
|
|
}
|
|
|
|
return analysis;
|
|
};
|
|
|
|
// By default, `TestReflectionHost#hasBaseClass()` returns `false`.
|
|
const analysis1 = analyzeDirective('TestDir1');
|
|
expect(analysis1.meta.usesInheritance).toBe(false);
|
|
|
|
// Tweak `TestReflectionHost#hasBaseClass()` to return true.
|
|
reflectionHost.hasBaseClassReturnValue = true;
|
|
|
|
const analysis2 = analyzeDirective('TestDir2');
|
|
expect(analysis2.meta.usesInheritance).toBe(true);
|
|
});
|
|
});
|
|
|
|
// Helpers
|
|
class TestReflectionHost extends TypeScriptReflectionHost {
|
|
hasBaseClassReturnValue = false;
|
|
|
|
hasBaseClass(clazz: ClassDeclaration): boolean { return this.hasBaseClassReturnValue; }
|
|
}
|
|
});
|