d5b87d32b0
Currently Ivy stores the element attributes into an array above the component def and passes it into the relevant instructions, however the problem is that upon minification the array will get a unique name which won't compress very well. These changes move the attributes array into the component def and pass in the index into the instructions instead.
Before:
```
const _c0 = ['foo', 'bar'];
SomeComp.ngComponentDef = defineComponent({
template: function() {
element(0, 'div', _c0);
}
});
```
After:
```
SomeComp.ngComponentDef = defineComponent({
consts: [['foo', 'bar']],
template: function() {
element(0, 'div', 0);
}
});
```
A couple of cases that this PR doesn't handle:
* Template references are still in a separate array.
* i18n attributes are still in a separate array.
PR Close #32798
80 lines
2.7 KiB
TypeScript
80 lines
2.7 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright Google Inc. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by an MIT-style license that can be
|
|
* found in the LICENSE file at https://angular.io/license
|
|
*/
|
|
|
|
import {ɵɵdefineComponent} from '../../src/render3/index';
|
|
import {ɵɵcontainer, ɵɵcontainerRefreshEnd, ɵɵcontainerRefreshStart, ɵɵelementEnd, ɵɵelementStart, ɵɵembeddedViewEnd, ɵɵembeddedViewStart, ɵɵtext} from '../../src/render3/instructions/all';
|
|
import {RenderFlags} from '../../src/render3/interfaces/definition';
|
|
|
|
import {document, renderComponent} from './render_util';
|
|
|
|
describe('iv perf test', () => {
|
|
|
|
const count = 100000;
|
|
const noOfIterations = 10;
|
|
|
|
describe('render', () => {
|
|
for (let iteration = 0; iteration < noOfIterations; iteration++) {
|
|
it(`${iteration}. create ${count} divs in DOM`, () => {
|
|
const start = new Date().getTime();
|
|
const container = document.createElement('div');
|
|
for (let i = 0; i < count; i++) {
|
|
const div = document.createElement('div');
|
|
div.appendChild(document.createTextNode('-'));
|
|
container.appendChild(div);
|
|
}
|
|
const end = new Date().getTime();
|
|
log(`${count} DIVs in DOM`, (end - start) / count);
|
|
});
|
|
|
|
it(`${iteration}. create ${count} divs in Render3`, () => {
|
|
class Component {
|
|
static ngFactoryDef = () => new Component;
|
|
static ngComponentDef = ɵɵdefineComponent({
|
|
type: Component,
|
|
selectors: [['div']],
|
|
decls: 1,
|
|
vars: 0,
|
|
template: function Template(rf: RenderFlags, ctx: any) {
|
|
if (rf & RenderFlags.Create) {
|
|
ɵɵcontainer(0);
|
|
}
|
|
if (rf & RenderFlags.Update) {
|
|
ɵɵcontainerRefreshStart(0);
|
|
{
|
|
for (let i = 0; i < count; i++) {
|
|
let rf0 = ɵɵembeddedViewStart(0, 2, 0);
|
|
{
|
|
if (rf0 & RenderFlags.Create) {
|
|
ɵɵelementStart(0, 'div');
|
|
ɵɵtext(1, '-');
|
|
ɵɵelementEnd();
|
|
}
|
|
}
|
|
ɵɵembeddedViewEnd();
|
|
}
|
|
}
|
|
ɵɵcontainerRefreshEnd();
|
|
}
|
|
}
|
|
});
|
|
}
|
|
|
|
const start = new Date().getTime();
|
|
renderComponent(Component);
|
|
const end = new Date().getTime();
|
|
log(`${count} DIVs in Render3`, (end - start) / count);
|
|
});
|
|
}
|
|
});
|
|
});
|
|
|
|
function log(text: string, duration: number) {
|
|
// tslint:disable-next-line:no-console
|
|
console.log(text, duration * 1000, 'ns');
|
|
}
|