George Kalpakas 0e201ea9d8 fix(docs-infra): fix scroll position restoration error in ScrollService (#29658) ...

Based on Google Analytics error report, the following error happens
occasionally (15% or total errors for 2019-03):

```
Cannot read property '0' of null TypeError: at t.scrollToPosition@main.js
```

This was a result of calling [ViewportScroller#scrollToPosition()][1]
with `null`, which in turn happens when calling
[ScrollService#scrollToPosition()][2] while `this.scrollPosition` is
`null`. This can be a result of a `popstate` event without an associated
history state.

This commit fixes the error by checking whether `this.scrollPosition` is
`null`, before using it with `scrollToPosition()`.

(It also refactors away the unneeded internal `popStateFired` property.)

[1]: https://github.com/angular/angular/blob/deca6a60d/packages/common/src/viewport_scroller.ts#L101-L105
[2]: https://github.com/angular/angular/blob/deca6a60d/aio/src/app/shared/scroll.service.ts#L158-L161

PR Close #29658

2019-04-02 10:26:49 -07:00

..

app

fix(docs-infra): fix scroll position restoration error in ScrollService (#29658)

2019-04-02 10:26:49 -07:00

assets

perf: pngcrush all pngs (#28479)

2019-02-01 13:56:02 -05:00

environments

test(aio): move reflect-metadata polyfills to test.ts (#23234)

2018-04-17 14:09:02 -07:00

extra-files

build(aio): generate sitemap from the generated pages (#21689)

2018-01-22 12:55:15 -08:00

styles

refactor: remove unused and duplicate CSS properties from styleguide examples (#28252)

2019-02-22 09:51:35 -08:00

testing

feat(docs-infra): add getting started widgets (#26059)

2018-11-02 10:34:53 -07:00

404-body.html

fix(docs-infra): improve a11y (#28086)

2019-01-16 17:37:45 -08:00

google385281288605d160.html

build(aio): add google webmaster tools verification file

2017-05-26 01:25:58 -07:00

ie-polyfills.js

fix(docs-infra): remove polyfill web-animations since we use Angular > 6 and we don't use AnimationBuilder (#28514)

2019-02-04 14:54:25 -05:00

index.html

docs: fix typo in description of angular.io/index.html (#29630)

2019-04-01 10:54:08 -07:00

karma.conf.js

build: remove travisci leftovers (#27979)

2019-01-09 10:41:16 -08:00

main.ts

feat(docs-infra): Convert AIO to use the new Service Worker 5.0.0. (#19795)

2018-08-27 16:30:42 -04:00

noop-worker-basic.js

feat(aio): provide noop service worker file

2017-05-26 14:24:41 +01:00

polyfills.ts

refactor(docs-infra): simplify custom-element polyfill setup (#25806)

2018-09-05 09:23:10 -07:00

pwa-manifest.json

fix(aio): make background transparent in 144x144 PWA icon (#23851)

2018-05-11 12:38:21 -04:00

styles.scss

style(aio): tidy up SCSS files

2017-03-13 12:55:11 -07:00

test.ts

test(docs-infra): remove reflect-metadata polyfill from aio tests (#27130)

2018-11-16 12:17:44 -08:00

tsconfig.app.json

build(docs-infra): turn on disableTypeScriptVersionCheck in angularCompilerOptions (#27536)

2018-12-18 13:20:02 -08:00

tsconfig.spec.json

test(aio): fix tests and update testing infra (#23234)

2018-04-17 14:09:02 -07:00

tslint.json

build(aio): update tslint and codelyzer (#23234)

2018-04-17 14:09:02 -07:00

typings.d.ts

build(aio): update project config for @angular/cli v1.0.0

2017-03-27 11:55:26 -07:00