build: remove dependency on @types/chokidar
(#35371)
We recently updated chokidar to `3.0.0`. The latest version of chokidar provides TypeScript types on its own and makes the extra dependency on the `@types` unnecessary. This seems to have caused the `build-packages-dist` script to fail with an error like: ``` [strictDeps] transitive dependency on external/npm/node_modules/chokidar/types/index.d.ts not allowed. Please add the BUILD target to your rule's deps. ``` It's unclear why that happens, but a reasonable theory would be that the TS compilation accidentally picked up the types from `chokidar` instead of `@types/chokidar`, and the strict deps `@bazel/typescript` check reported this as issue because it's not an explicit target dependency. PR Close #35371
This commit is contained in:

committed by
Alex Rickabaugh

parent
675b5aca0e
commit
8e12707f88
@ -30,8 +30,8 @@ ts_library(
|
||||
"//packages/compiler-cli/src/ngtsc/indexer",
|
||||
"//packages/compiler-cli/src/ngtsc/perf",
|
||||
"@npm//@bazel/typescript",
|
||||
"@npm//@types/chokidar",
|
||||
"@npm//@types/node",
|
||||
"@npm//chokidar",
|
||||
"@npm//fs-extra",
|
||||
"@npm//minimist",
|
||||
"@npm//reflect-metadata",
|
||||
|
Reference in New Issue
Block a user