cargdev/angular
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(upgrade): remove code setting id attribute. (#19182)

Browse Source 
The id was leftover from previous iterations of ngUpgrade and is
no longer needed. Moreover, setting it can clash with CSS usage of id.

Fixes #18446

PR Close #19182
This commit is contained in:
Rado Kirov
2017-09-05 22:44:32 -07:00
committed by Matias Niemelä
parent ea02b1ccfa
commit b20c5d2c37
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
packages/upgrade/src/common/downgrade_component_adapter.ts
View File

@ -31,7 +31,6 @@ export class DowngradeComponentAdapter {
private parentInjector: Injector, private $injector: angular.IInjectorService, private parentInjector: Injector, private $injector: angular.IInjectorService,
private $compile: angular.ICompileService, private $parse: angular.IParseService, private $compile: angular.ICompileService, private $parse: angular.IParseService,
private componentFactory: ComponentFactory<any>) { private componentFactory: ComponentFactory<any>) {
(this.element[0] as any).id = id;
this.componentScope = scope.$new(); this.componentScope = scope.$new();
} }